From 0bfd58a1a10eacec164ce478066e147adfe8fd9d Mon Sep 17 00:00:00 2001 From: Erik Karlsson <erik.karlsson@genexis.eu> Date: Tue, 7 Dec 2021 22:53:12 +0100 Subject: [PATCH] Use correct ranges with tr The tr command does not take regular expressions and should not be used with ranges such as [a-z] which furthermore can cause issues if unquoted as they are interpreted by the shell. --- intel_mips/base-files/lib/functions/iopsys-environment.sh | 2 +- .../base-files/lib/functions/iopsys-environment.sh | 2 +- iopsys-econet/base-files/lib/functions/iopsys-environment.sh | 2 +- .../mt7621/base-files/lib/functions/iopsys-environment.sh | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/intel_mips/base-files/lib/functions/iopsys-environment.sh b/intel_mips/base-files/lib/functions/iopsys-environment.sh index 97c0762d4..cc5cfb36a 100644 --- a/intel_mips/base-files/lib/functions/iopsys-environment.sh +++ b/intel_mips/base-files/lib/functions/iopsys-environment.sh @@ -1,5 +1,5 @@ get_base_macaddr() { - local basemac="$(fw_printenv -n ethaddr | tr ' ' ':' | sed 's/:$//' | tr [a-z] [A-Z])" + local basemac="$(fw_printenv -n ethaddr | tr ' ' ':' | sed 's/:$//' | tr 'a-z' 'A-Z')" echo "$basemac" } diff --git a/iopsys-brcm63xx-arm/base-files/lib/functions/iopsys-environment.sh b/iopsys-brcm63xx-arm/base-files/lib/functions/iopsys-environment.sh index 6a5b185a0..240162648 100644 --- a/iopsys-brcm63xx-arm/base-files/lib/functions/iopsys-environment.sh +++ b/iopsys-brcm63xx-arm/base-files/lib/functions/iopsys-environment.sh @@ -1,5 +1,5 @@ get_base_macaddr() { - local basemac="$(fw_printenv -n ethaddr | tr ' ' ':' | sed 's/:$//' | tr [a-z] [A-Z])" + local basemac="$(fw_printenv -n ethaddr | tr ' ' ':' | sed 's/:$//' | tr 'a-z' 'A-Z')" echo "$basemac" } diff --git a/iopsys-econet/base-files/lib/functions/iopsys-environment.sh b/iopsys-econet/base-files/lib/functions/iopsys-environment.sh index 391b06ff2..7be97c494 100644 --- a/iopsys-econet/base-files/lib/functions/iopsys-environment.sh +++ b/iopsys-econet/base-files/lib/functions/iopsys-environment.sh @@ -1,5 +1,5 @@ get_base_macaddr() { - local basemac="$(fw_printenv -n ethaddr | tr ' ' ':' | sed 's/:$//' | tr [a-z] [A-Z])" + local basemac="$(fw_printenv -n ethaddr | tr ' ' ':' | sed 's/:$//' | tr 'a-z' 'A-Z')" echo "$basemac" } diff --git a/iopsys-ramips/mt7621/base-files/lib/functions/iopsys-environment.sh b/iopsys-ramips/mt7621/base-files/lib/functions/iopsys-environment.sh index 417e6d07c..dfca6aa9d 100644 --- a/iopsys-ramips/mt7621/base-files/lib/functions/iopsys-environment.sh +++ b/iopsys-ramips/mt7621/base-files/lib/functions/iopsys-environment.sh @@ -1,5 +1,5 @@ get_base_macaddr() { - local basemac="$(fw_printenv -n ethaddr | tr ' ' ':' | sed 's/:$//' | tr [a-z] [A-Z])" + local basemac="$(fw_printenv -n ethaddr | tr ' ' ':' | sed 's/:$//' | tr 'a-z' 'A-Z')" echo "$basemac" } -- GitLab