1. 17 Mar, 2020 2 commits
    • Jaco Kroon's avatar
      Update main/backtrace.c to deal with changes in binutils 2.34. · 2ad64e97
      Jaco Kroon authored
      binutils 2.34 merged this commit:
      
      https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;\
      	h=fd3619828e94a24a92cddec42cbc0ab33352eeb4
      
      Which effectively does things like:
      
      -#define bfd_section_size(bfd, ptr) ((ptr)->size)
      -#define bfd_get_section_size(ptr) ((ptr)->size)
      
      +#define bfd_section_size(sec) ((sec)->size)
      
      So in order to remain backwards compatible we need to detect this API
      change, and adjust accordingly.  The simplest is to notice that the
      bfd_get_section_size and bfd_get_section_vma MACROs are no longer
      defined, and define then onto the new API.  The alternative is to litter
      the code with a number of #ifdef #else #endif splatters right through
      the code.
      
      Change-Id: I3efe0f8e8f3e338d16fcbc2b26a505367b6e172f
      2ad64e97
    • Sean Bright's avatar
      func_odbc.conf.sample: Clarify sample documentation · c4e09837
      Sean Bright authored
      ASTERISK-20325 #close
      
      Change-Id: I06cb9b467b0fd06c8af2a5aee049f872c09cc4b6
      c4e09837
  2. 13 Mar, 2020 4 commits
    • Sean Bright's avatar
      chan_vpb: Fix 'catching polymorphic type ... by value' error · 49cf8457
      Sean Bright authored
      Fixes the following compile error:
      
          chan_vpb.cc:2688:26: error: catching polymorphic type
              ‘class std::exception’ by value
      
      Change-Id: Ic87bc357d72427d77626735c83200fd278a7a649
      49cf8457
    • Sean Bright's avatar
      dns_txt: Add TXT record parsing support · d68f940f
      Sean Bright authored
      Change-Id: Ie0eca23b8e6f4c7d9846b6013d79099314d90ef5
      d68f940f
    • Joshua C. Colp's avatar
      audiohook: Don't allow audiohooks to attach to hung up channels. · 98d10d0a
      Joshua C. Colp authored
      Given a scenario where MixMonitor was initiated over AMI it
      was possible for the channel and MixMonitor thread to remain
      alive past hang up of the channel. This scenario required
      the AMI initiated MixMonitor to retrieve the channel, a
      hangup to occur on the channel in another thread, and then
      for MixMonitor to actually start. If this occurred the
      MixMonitor thread would remain alive indefinitely and
      the channel reference would remain.
      
      This change ensures that audiohooks are never able to
      be attached to channels that have been hung up. An
      additional fix has also been done in app_mixmonitor to
      properly release the channel reference if this occurs.
      
      ASTERISK-28780
      
      Change-Id: I8044c06daa06f0f16607788c596f55623be26f58
      98d10d0a
    • George Joseph's avatar
      CI: Create generic jenkinsfile · 00a7e4b5
      George Joseph authored
      This is a generic jenkinsfile to build Asterisk and optionally
      perform one or more of the following:
       * Publish the API docs to the wiki
       * Run the Unit tests
       * Run Testsuite Tests
      
      This job can be triggered manually from Jenkins or be triggered
      automatically on a schedule based on a cron string.
      
      Change-Id: Id9d22a778a1916b666e0e700af2b9f1bacda0852
      00a7e4b5
  3. 12 Mar, 2020 1 commit
    • Torrey Searle's avatar
      res_rtp_asterisk: Send correct sender SSRC when p2p bridge in use · a1dba820
      Torrey Searle authored
      bridge_p2p_rtp_write will forward rtp to the bridged rtp instance
      without modifying the ssrc.  However, it is not updating the SSRC
      in the bridged rtp.  Thus, when SSRC packets are generated, they
      have the correct SSRC for the sender.
      
      ASTERISK-28773 #close
      
      Change-Id: I39f923bde28ebb4f0fddc926b92494aed294a478
      a1dba820
  4. 10 Mar, 2020 2 commits
  5. 09 Mar, 2020 6 commits
  6. 06 Mar, 2020 2 commits
    • Sean Bright's avatar
      enum.c: Add support for regular expression flag in NAPTR record · 517224ce
      Sean Bright authored
      A regular expression in a NAPTR response record can have a trailing
      'i' flag to indicate that the expression should be evaluated in a
      case-insensitive way. We were not checking for that flag which caused
      the record parsing to fail on otherwise valid input.
      
      Although this change will initially go into Asterisk 13, 16, and 17,
      it is my intention to replace the majority of this code in 16 and up -
      including this fix - by changing enum.c to consume the new DNS API
      which duplicates most of this logic already. Asterisk 13 doesn't have
      the DNS API, so this fix will be as good as it gets.
      
      ASTERISK-26711 #close
      Reported by: Vitold
      
      Change-Id: I33943a5b3e7539c6dca3a5079982ee15a08186f0
      517224ce
    • Jared Smith's avatar
      indications.conf.sample: Add indication tones for Indonesia · 0a7fe309
      Jared Smith authored
      These tones come from http://www.itu.int/ITU-T/inr/forms/files/tones-0203.pdf
      
      ASTERISK-23407
      
      Change-Id: I48e2285f1e5bb29b3335f762006f66c423d0fcb8
      0a7fe309
  7. 05 Mar, 2020 2 commits
  8. 04 Mar, 2020 4 commits
  9. 03 Mar, 2020 2 commits
    • Kevin Harwell's avatar
      codec negotiation: add incoming_call_offer_prefs option · 06dada3f
      Kevin Harwell authored
      Add a new option, incoming_call_offer_pref, to res_pjsip endpoints that
      specifies the preferred order of codecs after receiving an offer.
      
      This patch does the following:
      
        Adds a new enumeration, ast_sip_call_codec_pref, used by the the new
      configuration option that's added to the endpoint media structure.
      
        Adds a new ast_sip_session_caps structure that's set for each session media
      object.
      
        Creates a new file, res_pjsip_session_caps that "implements" the new
      structure and option, and is compiled into the res_pjsip_session library.
      
      ASTERISK-28756 #close
      
      Change-Id: I35e7a2a0c236cfb6bd9cdf89539f57a1ffefc76f
      06dada3f
    • Joshua C. Colp's avatar
      res_rtp_asterisk: Improve video performance in certain networks. · 87fda066
      Joshua C. Colp authored
      The receive buffer will now grow if we end up flushing the
      receive queue after not receiving the expected packet in time.
      This is done in hopes that if this is encountered again the
      extra buffer size will allow more time to pass and any missing
      packets to be received.
      
      The send buffer will now grow if we are asked for packets and
      can't find them. This is done in hopes that the packets are
      from the past and have simply been expired. If so then in
      the future with the extra buffer space the packets should be
      available.
      
      Sequence number cycling has been handled so that the
      correct sequence number is calculated and used in
      various places, including for sorting packets and
      for determining if a packet is old or not.
      
      NACK sending is now more aggressive. If a substantial number
      of missing sequence numbers are added a NACK will be sent
      immediately. Afterwards once the receive buffer reaches 25%
      a single NACK is sent. If the buffer continues to grow and
      reaches 50% or greater a NACK will be sent for each received
      future packet to aggressively ask the remote endpoint to
      retransmit.
      
      ASTERISK-28764
      
      Change-Id: I97633dfa8a09a7889cef815b2be369f3f0314b41
      87fda066
  10. 02 Mar, 2020 2 commits
    • Kevin Harwell's avatar
      f8a85260
    • Kevin Harwell's avatar
      message & stasis/messaging: make text message variables work in ARI · a715cf5a
      Kevin Harwell authored
      When a text message was received any associated variable was not written to
      the ARI TextMessageReceived event. This occurred because Asterisk only wrote
      out "send" variables. However, even those "send" variables would fail ARI
      validation due to a TextMessageVariable formatting bug.
      
      Since it seems the TextMessageReceived event has never been able to include
      actual variables it was decided to remove the TextMessageVariable object type
      from ARI, and simply return a JSON object of key/value pairs for variables.
      This aligns more with how the ARI sendMessage handles variables, and other
      places in ARI.
      
      ASTERISK-28755 #close
      
      Change-Id: Ia6051c01a53b30cf7edef84c27df4ed4479b8b6f
      a715cf5a
  11. 27 Feb, 2020 6 commits
  12. 26 Feb, 2020 2 commits
    • Sebastian Kemper's avatar
      check_expr2: fix cross-compile/hardening issues · b7fbb9c4
      Sebastian Kemper authored
      When building check_expr2 with ASLR PIE hardening enabled the linker
      fails. This is resolved by adding the regular compiler flags when
      building the object files from ast_expr2f.c and ast_expr2.c.
      
      Note: The STANDALONE define is removed because it is already defined in
      _ASTCFLAGS. YY_NO_INPUT is defined so that the compile survives
      '--enable-dev-mode'.
      
      Also, a Makefile variable "CROSS_COMPILING" is added so that the
      build system doesn't try to run check_expr2 when cross-compiling,
      because that will fail the build as will.
      
      ASTERISK-28685 #close
      Signed-off-by: default avatarSebastian Kemper <sebastian_ml@gmx.net>
      Change-Id: If435b7db9f9ad8266245bda51c81c220f9658915
      b7fbb9c4
    • Torrey Searle's avatar
      res/res_pjsip_sdp_rtp: Fix MOH transitions · 77c9ba8e
      Torrey Searle authored
      Update the state of remote_hold immediately on receipt of remote
      SDP so that the information is available when building the SDP
      answer
      
      ASTERISK-28754 #close
      
      Change-Id: I7026032a807e9c95081cb8f060400b05deb4836f
      77c9ba8e
  13. 25 Feb, 2020 1 commit
  14. 24 Feb, 2020 3 commits
    • Kevin Harwell's avatar
      format_cap: make function parameters 'const' · 1e1651b4
      Kevin Harwell authored
      There were a couple places where the format cap function parameter was not
      'const' when it should have been. This patch makes them 'const'.
      
      Change-Id: Ife753fb16a962d842a6b44f45363a61a66bfdb2e
      1e1651b4
    • Walter Doekes's avatar
      say: Remove unused "plural" option from main/say · 0b5c6fdd
      Walter Doekes authored
      There are exceptions for plural objects, but they are detected using the
      supplied NUMBER, not using an extra option.
      
      Change-Id: I95d1d1b2796b1aba92048a2dbae8a3856ed8a113
      0b5c6fdd
    • Jaco Kroon's avatar
      addons/res_config_mysql: silense warnings about printf format errors. · 5cd7230f
      Jaco Kroon authored
      Warnings without this:
      
      res_config_mysql.c: In function 'update2_mysql':
      res_config_mysql.c:741:15: warning: format '%llu' expects argument of type
          'long long unsigned int', but argument 6 has type 'my_ulonglong'
          {aka 'long unsigned int'} [-Wformat=]
      ast_debug(1, "MySQL RealTime: Updated %llu rows on table: %s\n",
          numrows, tablename);
      
      (reformatted for readability within line-wrap)
      
      Change-Id: I2af4d419a37c1a7eeee750cf9ae4a9a2b3a37fd3
      5cd7230f
  15. 21 Feb, 2020 1 commit