Commit 5e02f944 authored by Hans Dedecker's avatar Hans Dedecker

system-linux: fix resource leak

Fix cb leak in case invalid type is specified in system_if_clear_entries
Detected by Coverity in CID1431183
Signed-off-by: default avatarHans Dedecker <dedeckeh@gmail.com>
parent 899f168b
......@@ -985,7 +985,7 @@ static void
system_if_clear_entries(struct device *dev, int type, int af)
{
struct clear_data clr;
struct nl_cb *cb = nl_cb_alloc(NL_CB_DEFAULT);
struct nl_cb *cb;
struct rtmsg rtm = {
.rtm_family = af,
.rtm_flags = RTM_F_CLONED,
......@@ -993,9 +993,6 @@ system_if_clear_entries(struct device *dev, int type, int af)
int flags = NLM_F_DUMP;
int pending = 1;
if (!cb)
return;
clr.af = af;
clr.dev = dev;
clr.type = type;
......@@ -1011,6 +1008,10 @@ system_if_clear_entries(struct device *dev, int type, int af)
return;
}
cb = nl_cb_alloc(NL_CB_DEFAULT);
if (!cb)
return;
clr.msg = nlmsg_alloc_simple(type, flags);
if (!clr.msg)
goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment