From f8caf13cd94840dffa8b73c60eb3fbdfc1763e1c Mon Sep 17 00:00:00 2001 From: Maxim Menshikov <maxim.menshikov@iopsys.eu> Date: Fri, 24 Jun 2022 20:15:08 +0300 Subject: [PATCH] easy-soc-libs: start using more GCC diagnostics --- Makefile.diag.inc | 5 +++++ libdsl/Makefile | 3 +++ libeasy/Makefile | 4 +++- libethernet/Makefile | 4 +++- libqos/Makefile | 4 +++- libwifi/Makefile | 6 ++++-- 6 files changed, 21 insertions(+), 5 deletions(-) create mode 100644 Makefile.diag.inc diff --git a/Makefile.diag.inc b/Makefile.diag.inc new file mode 100644 index 00000000..7b6031f0 --- /dev/null +++ b/Makefile.diag.inc @@ -0,0 +1,5 @@ +DIAG_WALL_CFLAGS = -Waddress -Warray-bounds=1 -Warray-compare -Warray-parameter=2 -Wbool-compare -Wbool-operation -Wchar-subscripts -Wcomment -Wdangling-pointer=2 -Wduplicate-decl-specifier -Wenum-compare -Wenum-int-mismatch -Wformat -Wformat-overflow -Wformat-truncation -Wint-in-bool-context -Wimplicit -Wimplicit-int -Wimplicit-function-declaration -Winit-self -Wlogical-not-parentheses -Wmain -Wmaybe-uninitialized -Wmemset-elt-size -Wmemset-transposed-args -Wmisleading-indentation -Wmismatched-dealloc -Wmismatched-new-delete -Wmissing-attributes -Wmissing-braces -Wmultistatement-macros -Wnarrowing -Wnonnull -Wnonnull-compare -Wopenmp-simd -Wparentheses -Wpessimizing-move -Wpointer-sign -Wrange-loop-construct -Wreorder -Wrestrict -Wreturn-type -Wsequence-point -Wsign-compare -Wsizeof-array-div -Wsizeof-pointer-div -Wsizeof-pointer-memaccess -Wstrict-aliasing -Wstrict-overflow=1 -Wswitch -Wtautological-compare -Wtrigraphs -Wuninitialized -Wunknown-pragmas -Wunused-function -Wunused-label -Wunused-value -Wunused-variable -Wuse-after-free=3 -Wvla-parameter -Wvolatile-register-var -Wzero-length-bounds + +DIAG_CFLAGS = $(DIAGNOSTIC_WALL_CFLAGS) -Wshadow -Wdouble-promotion -Wformat=2 -Wundef -fno-common -Wconversion -Wstrict-prototypes -Wno-declaration-after-statement + +DIAG_ERROR_CFLAG \ No newline at end of file diff --git a/libdsl/Makefile b/libdsl/Makefile index a749eb56..01004ef0 100644 --- a/libdsl/Makefile +++ b/libdsl/Makefile @@ -1,5 +1,8 @@ +-include ../Makefile.diag.inc + LIBDSL = libdsl.so +CFLAGS += $(DIAG_CFLAGS) -Werror HEADER_DEPS := xdsl.h common.h xtm.h ifeq ($(PLATFORM),BROADCOM) diff --git a/libeasy/Makefile b/libeasy/Makefile index a353bf06..d4d8d3e9 100644 --- a/libeasy/Makefile +++ b/libeasy/Makefile @@ -1,5 +1,7 @@ - CC = gcc + +-include ../Makefile.diag.inc +CFLAGS += $(DIAG_CFLAGS) -Werror #CFLAGS += -O2 -Wall -g -fvisibility=hidden LIBEASY_CFLAGS = -fvisibility=hidden diff --git a/libethernet/Makefile b/libethernet/Makefile index a3b7b710..b5363db2 100644 --- a/libethernet/Makefile +++ b/libethernet/Makefile @@ -1,5 +1,7 @@ CC = gcc -CFLAGS = -O2 -Wall -g + +-include ../Makefile.diag.inc +CFLAGS = -O2 -g $(DIAG_CFLAGS) -Werror LIBETH_CFLAGS += -I. -I../libeasy LIBETH_LDFLAGS += -L../libeasy diff --git a/libqos/Makefile b/libqos/Makefile index c7ce16f6..2093ec78 100644 --- a/libqos/Makefile +++ b/libqos/Makefile @@ -1,5 +1,7 @@ CC = gcc -CFLAGS = -O2 -Wall -g + +-include ../Makefile.diag.inc +CFLAGS = -O2 -g $(DIAG_CFLAGS) -Werror LIBQOS_CFLAGS += -I./include -I../libeasy LIBQOS_LDFLAGS += -L../libeasy diff --git a/libwifi/Makefile b/libwifi/Makefile index 200ab965..e06562c3 100644 --- a/libwifi/Makefile +++ b/libwifi/Makefile @@ -1,6 +1,8 @@ - CC ?= gcc -CFLAGS += -O2 -Wall -g + +-include ../Makefile.diag.inc +CFLAGS = -O2 -g $(DIAG_CFLAGS) -Werror + LIBWIFI_CFLAGS += -I. -I../libeasy LIBWIFI_LDFLAGS += -L../libeasy -- GitLab