From 2936ae4985b2124955a0205e577de8324ee6cdf9 Mon Sep 17 00:00:00 2001 From: "Benedetto, Salvatore" <salvatore.benedetto@intel.com> Date: Tue, 13 Mar 2018 13:18:33 +0100 Subject: [PATCH] Merge pull request #273 in SW_PON/linux from bugfix/UGW_SW-23348-kernel-dump-observed-while-executing-cdr-and-nbt to xrx500 * commit 'd160d55eb68343cc92cd3e84e7c85ebd49ba7bd4': spi: ltq_ssc - fix ifx_validate_params() spi: ltq_ssc - Remove dump_stack call --- drivers/spi/ltq_ssc.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/spi/ltq_ssc.c b/drivers/spi/ltq_ssc.c index f682731ef..e11fe7df2 100644 --- a/drivers/spi/ltq_ssc.c +++ b/drivers/spi/ltq_ssc.c @@ -2864,25 +2864,19 @@ static int ifx_validate_params(IFX_SSC_HANDLE handler, char *txbuf, int txsize, if (!handler) { LOGF_KLOG_ERROR("%s: invalid handler\n", __func__); + dump_stack(); goto out; } - if (!rxbuf || rxsize == 0) { - LOGF_KLOG_ERROR("%s: invalid rxbuf=%x rxsize=%d\n", - __func__, rxbuf, rxsize); + if (!rxbuf && rxsize == 0 && !txbuf && txsize == 0) { + LOGF_KLOG_ERROR("%s: invalid data\n"); + dump_stack(); goto out; } - if (!txbuf || txsize == 0) { - LOGF_KLOG_ERROR("%s: invalid txbuf=%x txsize=%d\n", - __func__, txbuf, txsize); - goto out; - } status = 0; out: - dump_stack(); - return status; } -- GitLab