Skip to content
Snippets Groups Projects
Commit fbb9b1f8 authored by Jo-Philipp Wich's avatar Jo-Philipp Wich
Browse files

build: ensure that dash isn't prepended twice to abi version suffix

The ABIV_$(pkgname) variable already is formatted so return it as-is from
the GetABISuffix macro and only filter through FormatABISuffix if we read
the raw ABI version value from a version stamp file.

This ensures that binary intra-package dependencies on ABI versioned
libraries are properly formatted.

Ref: https://github.com/openwrt/packages/issues/15871


Fixes: f6a03bff ("build: prepend ABI suffixes with a dash if package name ends with digit")
Signed-off-by: default avatarJo-Philipp Wich <jo@mein.io>
parent 94601963
Branches
Tags
1 merge request!79Merge OpenWrt 22.03.0-rc4
...@@ -43,7 +43,7 @@ endef ...@@ -43,7 +43,7 @@ endef
# 1: package name # 1: package name
define GetABISuffix define GetABISuffix
$(call FormatABISuffix,$(1),$(if $(ABIV_$(1)),$(ABIV_$(1)),$(foreach v,$(wildcard $(STAGING_DIR)/pkginfo/$(1).version),$(shell cat $(v))))) $(if $(ABIV_$(1)),$(ABIV_$(1)),$(call FormatABISuffix,$(1),$(foreach v,$(wildcard $(STAGING_DIR)/pkginfo/$(1).version),$(shell cat $(v)))))
endef endef
# 1: package name # 1: package name
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment