From a24a210629a56c6af6740b74b649829d2137fbeb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ionu=C8=9B-Alex=20Oprea?= <ionutalexoprea@gmail.com>
Date: Tue, 26 Jun 2018 15:13:43 +0200
Subject: [PATCH] suggestion title

suggestion text
---
 dongle.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dongle.c b/dongle.c
index 03579f2..ef4d5d9 100644
--- a/dongle.c
+++ b/dongle.c
@@ -592,7 +592,7 @@ static int list_to_blob(struct blob_buf *bb)
 	int rv;
 
 	memset(bb, 0, sizeof(*bb));
-	rv = blob_buf_init(bb, 0);
+	rv = blob_buf_init(bb, 0); // no blob_buf_free if this fails
 	if (rv != 0)
 		goto fail;
 
@@ -635,7 +635,7 @@ fail_string:
 fail_table:
 fail_arr:
 fail:
-	return UBUS_STATUS_UNKNOWN_ERROR;
+	return UBUS_STATUS_UNKNOWN_ERROR; // this function should be UBUS_STATUS_* unaware.
 }
 
 static int print_list(struct ubus_context *ctx, struct ubus_object *obj,
@@ -686,7 +686,7 @@ static int alert(struct ubus_context *ctx, struct ubus_object *obj,
 	usb_path = (char *)blobmsg_data(tb[USB_PATH]);
 
 	get_devices_from_path(usb_path);
-	return 0;
+	return 0; // UBUS_STATUS_OK ?
 fail:
 	return UBUS_STATUS_INVALID_ARGUMENT;
 }
-- 
GitLab