From b48f5be7dc2a02fbf05786e25b8f5e905189fcdc Mon Sep 17 00:00:00 2001
From: Arun Muthusamy <arun.muthusamy@inteno.se>
Date: Mon, 11 Jun 2018 12:44:39 +0200
Subject: [PATCH] swap sprintf to snprintf

---
 libmobile_hilink.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/libmobile_hilink.c b/libmobile_hilink.c
index 860da67..93d797d 100644
--- a/libmobile_hilink.c
+++ b/libmobile_hilink.c
@@ -642,7 +642,7 @@ struct json_object *mobile_delete_apn_profile_hilink(int profile_name_location)
 	struct write_result *result;
 	struct json_object *result_json;
 
-	sprintf(post_query, "<request><Delete>%d</Delete><SetDefault>1</SetDefault><Modify>0</Modify></request>", profile_name_location);
+	snprintf(post_query, 512, "<request><Delete>%d</Delete><SetDefault>1</SetDefault><Modify>0</Modify></request>", profile_name_location);
 
 	result = post_request(sess_tok_url, api_url, post_query);
 	if (!result)
@@ -671,7 +671,7 @@ struct json_object *mobile_sms_read_hilink(int sms_location)
 	struct write_result *result;
 	struct json_object *result_json;
 
-	sprintf(post_query, "<request><Index>%d</Index></request>", sms_location);
+	snprintf(post_query, 256, "<request><Index>%d</Index></request>", sms_location);
 
 	result = post_request(sess_tok_url, api_url, post_query);
 	if (!result)
@@ -700,7 +700,7 @@ struct json_object *mobile_sms_delete_hilink(int sms_location)
 	struct write_result *result;
 	struct json_object *result_json;
 
-	sprintf(post_query, "<request><Index>%d</Index></request>", sms_location);
+	snprintf(post_query, 256, "<request><Index>%d</Index></request>", sms_location);
 
 	result = post_request(sess_tok_url, api_url, post_query);
 	if (!result)
@@ -838,7 +838,7 @@ struct json_object *mobile_set_connection_type_hilink(int connection_type)
 	struct write_result *result;
 	struct json_object *result_json;
 
-	sprintf(post_query, "<request><NetworkMode>%d</NetworkMode><NetworkBand>3FFFFFFF</NetworkBand><LTEBand>7FFFFFFFFFFFFFFF</LTEBand></request>", connection_type);
+	snprintf(post_query, 256, "<request><NetworkMode>%d</NetworkMode><NetworkBand>3FFFFFFF</NetworkBand><LTEBand>7FFFFFFFFFFFFFFF</LTEBand></request>", connection_type);
 
 	result = post_request(sess_tok_url, api_url, post_query);
 	if (!result)
@@ -867,7 +867,7 @@ struct json_object *data_roaming(int action)
 	struct write_result *result;
 	struct json_object *result_json;
 
-	sprintf(post_query, "<request><RoamAutoConnectEnable>%d</RoamAutoConnectEnable><MaxIdelTime>600</MaxIdelTime><ConnectMode>0</ConnectMode><MTU>1500</MTU><auto_dial_switch>1</auto_dial_switch><pdp_always_on>0</pdp_always_on></request>", action);
+	snprintf(post_query, 256, "<request><RoamAutoConnectEnable>%d</RoamAutoConnectEnable><MaxIdelTime>600</MaxIdelTime><ConnectMode>0</ConnectMode><MTU>1500</MTU><auto_dial_switch>1</auto_dial_switch><pdp_always_on>0</pdp_always_on></request>", action);
 
 	result = post_request(sess_tok_url, api_url, post_query);
 	if (!result)
@@ -908,7 +908,7 @@ struct json_object *pin_action(char *type, char *current_pin, char *new_pin, cha
 	struct write_result *result;
 	struct json_object *result_json;
 
-	sprintf(post_query, "<request><OperateType>%s</OperateType><CurrentPin>%s</CurrentPin><NewPin>%s</NewPin><PukCode>%s</PukCode></request>", type, current_pin, new_pin, puk);
+	sprintf(post_query, 256, "<request><OperateType>%s</OperateType><CurrentPin>%s</CurrentPin><NewPin>%s</NewPin><PukCode>%s</PukCode></request>", type, current_pin, new_pin, puk);
 
 	result = post_request(sess_tok_url, api_url, post_query);
 	if (!result)
-- 
GitLab