From 38312245c4632662457f1c355eba7203255978ce Mon Sep 17 00:00:00 2001
From: Jakob Olsson <jakob.olsson@iopsys.eu>
Date: Thu, 9 Sep 2021 14:14:29 +0200
Subject: [PATCH] cntlr: periodic topology query compilation fixes

---
 src/core/cntlr.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/core/cntlr.c b/src/core/cntlr.c
index d31231b7..fb345de9 100644
--- a/src/core/cntlr.c
+++ b/src/core/cntlr.c
@@ -1650,28 +1650,28 @@ static uint32_t ubus_get_topology_object(struct ubus_context *ctx)
 #endif
 
 
-static void cntlr_signal_periodic_run(struct uloop_timeout *t)
+static void cntlr_query_nodes(struct uloop_timeout *t)
 {
 	struct controller *c = container_of(t, struct controller, query_nodes);
 	struct node *n;
 
-	list_for_each_entry_safe(n, &c->nodelist, list) {
+	list_for_each_entry(n, &c->nodelist, list) {
 		struct cmdu_buff *cmdu;
 
 		cmdu = cntlr_gen_bk_caps_query(c, n->alid);
-		if (!cmdu) {
+		if (cmdu) {
 			send_cmdu(c, cmdu);
 			cmdu_free(cmdu);
 		}
 
 		cmdu = cntlr_gen_ap_capability_query(c, n->alid);
-		if (!cmdu) {
+		if (cmdu) {
 			send_cmdu(c, cmdu);
 			cmdu_free(cmdu);
 		}
 
 		cmdu = cntlr_gen_topology_query(c, n->alid);
-		if (!cmdu) {
+		if (cmdu) {
 			send_cmdu(c, cmdu);
 			cmdu_free(cmdu);
 		}
@@ -2070,7 +2070,6 @@ int start_controller(void)
 	c->radar_timer.cb = cntlr_radar_exit;
 	c->signal_handler.cb = cntlr_signal_periodic_run;
 	c->query_nodes.cb = cntlr_query_nodes;
-	//c->bcn_metrics_timer.cb = cntlr_bcn_metrics_parse;
 
 	uloop_timeout_set(&c->heartbeat, 5 * 1000);
 	uloop_timeout_set(&c->discovery_timer, 0);
-- 
GitLab