Skip to content
Snippets Groups Projects
  • David M. Lee's avatar
    cf9324b2
    Move more channel events to Stasis; move res_json.c to main/json.c. · cf9324b2
    David M. Lee authored
    This patch started out simply as fixing the bouncing tests introduced
    in r382685, but required some other changes to give it a decent
    implementation.
    
    To fix the bouncing tests, the UserEvent and Newexten AMI events
    needed to be refactored to dispatch via Stasis. Dispatching directly
    to AMI resulted in those events sometimes getting ahead of the
    associated Newchannel events, which would understandably confuse anyone.
    
    I found that instead of creating a zillion different message types and
    structures associated with them, it would be preferable to define a
    message type that has a channel snapshot and a blob of structured data
    with a small bit of additional information. The JSON object model
    provides a very nice way of representing structured data, so I went
    with that.
    
     * Move JSON support from res_json.c to main/json.c
       * Made libjansson-dev a required dependency
     * Added an ast_channel_blob message type, which has a channel
       snapshot and JSON blob of data.
     * Changed UserEvent and Newexten events so that they are dispatched
       via ast_channel_blob messages on the channel's topic.
     * Got rid of the ast_channel_varset message; used ast_channel_blob
       instead.
     * Extracted the manager functions converting Stasis channel events to
       AMI events into manager_channel.c.
    
    (issue ASTERISK-21096)
    Review: https://reviewboard.asterisk.org/r/2381/
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@383579 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    cf9324b2
    History
    Move more channel events to Stasis; move res_json.c to main/json.c.
    David M. Lee authored
    This patch started out simply as fixing the bouncing tests introduced
    in r382685, but required some other changes to give it a decent
    implementation.
    
    To fix the bouncing tests, the UserEvent and Newexten AMI events
    needed to be refactored to dispatch via Stasis. Dispatching directly
    to AMI resulted in those events sometimes getting ahead of the
    associated Newchannel events, which would understandably confuse anyone.
    
    I found that instead of creating a zillion different message types and
    structures associated with them, it would be preferable to define a
    message type that has a channel snapshot and a blob of structured data
    with a small bit of additional information. The JSON object model
    provides a very nice way of representing structured data, so I went
    with that.
    
     * Move JSON support from res_json.c to main/json.c
       * Made libjansson-dev a required dependency
     * Added an ast_channel_blob message type, which has a channel
       snapshot and JSON blob of data.
     * Changed UserEvent and Newexten events so that they are dispatched
       via ast_channel_blob messages on the channel's topic.
     * Got rid of the ast_channel_varset message; used ast_channel_blob
       instead.
     * Extracted the manager functions converting Stasis channel events to
       AMI events into manager_channel.c.
    
    (issue ASTERISK-21096)
    Review: https://reviewboard.asterisk.org/r/2381/
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@383579 65c4cc65-6c06-0410-ace0-fbb531ad65f3