From 0a8b3d34673277b70be6b0e8ac50191b1f3c72c6 Mon Sep 17 00:00:00 2001
From: Naveen Albert <asterisk@phreaknet.org>
Date: Tue, 29 Mar 2022 23:47:41 +0000
Subject: [PATCH] chan_dahdi: Don't allow MWI FSK if channel not idle.
For lines that have mailboxes configured on them, with
FSK MWI, DAHDI will periodically try to dispatch FSK
to update MWI. However, this is never supposed to be
done when a channel is not idle.
There is currently an edge case where MWI FSK can
extraneously get spooled for the channel if a caller
hook flashes and hangs up, which triggers a recall ring.
After one ring, the on hook time threshold in this if
condition has been satisfied and an MWI update is spooled.
This means that when the phone is picked up again, the
answerer gets an FSK spill before being reconnected to
the party on hold.
To prevent this, we now explicitly check to ensure that
subchannel 0 has no owner. There is no owner when DAHDI
channels are idle, but if the channel is "in use" in some
way (such as in the aforementioned scenario), then there
is an owner, and we shouldn't process MWI at this time.
ASTERISK-28518 #close
Change-Id: Ia3904434fd81688d71742f7e84358b7e1c38e92a
---
channels/chan_dahdi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/channels/chan_dahdi.c b/channels/chan_dahdi.c
index 5f64575194..26bb29096e 100644
--- a/channels/chan_dahdi.c
+++ b/channels/chan_dahdi.c
@@ -11573,6 +11573,7 @@ static void *do_monitor(void *data)
&& !analog_p->fxsoffhookstate
&& !last->owner
&& !ast_strlen_zero(last->mailbox)
+ && !analog_p->subs[SUB_REAL].owner /* could be a recall ring from a flash hook hold */
&& (thispass - analog_p->onhooktime > 3)) {
res = has_voicemail(last);
if (analog_p->msgstate != res) {
--
GitLab