From 1359f673bbd8feaa362ad0c07cea357d234d6176 Mon Sep 17 00:00:00 2001
From: neutrino88 <emmanuel.buu@ives.fr>
Date: Wed, 3 Oct 2018 17:51:49 -0400
Subject: [PATCH] core/frame: generate correct T.140 payload in
ast_sendtext_data()
ast_sendtext_data() would create an incorrect T.140 text frame which
length include the null terminator byte. It causes ultimately RTP
packets to be send with this trailing 0. The proposed fix just set the
correct length to the text frame
ASTERISK-28089
Reported by: Emmanuel BUU
Tested by: Emmanuel BUU
Change-Id: I7ab1b9ed1e21683b2b667ea0a59d9aba3c77dd96
---
main/channel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/main/channel.c b/main/channel.c
index 5fc9cd83a3..d13d3f5f8e 100644
--- a/main/channel.c
+++ b/main/channel.c
@@ -4905,7 +4905,8 @@ int ast_sendtext_data(struct ast_channel *chan, struct ast_msg_data *msg)
&& (ast_strlen_zero(content_type) || ast_begins_with(content_type, "text/"))
&& (ast_format_cap_has_type(ast_channel_nativeformats(chan), AST_MEDIA_TYPE_TEXT))) {
struct ast_frame f;
- size_t body_len = strlen(body) + 1;
+ /* T.140 payload does not include the null byte terminator */
+ size_t body_len = strlen(body);
/* Process as T.140 text (moved here from ast_sendtext() */
memset(&f, 0, sizeof(f));
--
GitLab