From 24d1d23a93bb35733361d7b1ab407ee6d43f7d24 Mon Sep 17 00:00:00 2001
From: Luigi Rizzo <rizzo@icir.org>
Date: Sat, 3 Jun 2006 23:34:01 +0000
Subject: [PATCH] mark XXX some places where there is a return right before a
large "else" block, which is suitable for a reduction of the nesting depth.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31870 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---
channels/chan_sip.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 4b8947f463..63897dcf30 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -6750,6 +6750,9 @@ static enum check_auth_result check_auth(struct sip_pvt *p, struct sip_request *
sip_scheddestroy(p, SIP_TRANS_TIMEOUT);
return AUTH_CHALLENGE_SENT;
} else { /* We have auth, so check it */
+
+ /* XXX reduce nesting here */
+
/* Whoever came up with the authentication section of SIP can suck my %&#$&* for not putting
an example in the spec of just what it is you're doing a hash on. */
char a1_hash[256];
@@ -12602,6 +12605,8 @@ static int handle_request_subscribe(struct sip_pvt *p, struct sip_request *req,
ast_set_flag(&p->flags[0], SIP_NEEDDESTROY);
return 0;
} else {
+ /* XXX reduce nesting here */
+
/* Initialize tag for new subscriptions */
if (ast_strlen_zero(p->tag))
make_our_tag(p->tag, sizeof(p->tag));
@@ -12700,6 +12705,7 @@ static int handle_request_subscribe(struct sip_pvt *p, struct sip_request *req,
ast_set_flag(&p->flags[0], SIP_NEEDDESTROY);
return 0;
} else {
+ /* XXX reduce nesting here */
struct sip_pvt *p_old;
transmit_response(p, "200 OK", req);
--
GitLab