From 338e8c0f0fd15d3b9947d874107d3bcd87c289d6 Mon Sep 17 00:00:00 2001 From: Richard Mudgett <rmudgett@digium.com> Date: Sun, 26 Nov 2017 09:44:51 -0600 Subject: [PATCH] res_ari: Fix inverted test giving wrong error message. The patch for ASTERISK_24560 inverted a test checking if the bridge name is being updated to a different name. * Fix the test to return "Changing bridge name is not implemented" when someone attempts to change the bridge name. ASTERISK-27445 Change-Id: I4b70bf08b0e02e016108b077ff75b345dec12fc9 --- res/ari/resource_bridges.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/res/ari/resource_bridges.c b/res/ari/resource_bridges.c index e08df7d8b1..019cdea22b 100644 --- a/res/ari/resource_bridges.c +++ b/res/ari/resource_bridges.c @@ -962,13 +962,12 @@ void ast_ari_bridges_create_with_id(struct ast_variable *headers, if (bridge) { /* update */ - if (!ast_strlen_zero(args->name)) { - if (!strcmp(args->name, bridge->name)) { - ast_ari_response_error( - response, 500, "Internal Error", - "Changing bridge name is not implemented"); - return; - } + if (!ast_strlen_zero(args->name) + && strcmp(args->name, bridge->name)) { + ast_ari_response_error( + response, 500, "Internal Error", + "Changing bridge name is not implemented"); + return; } if (!ast_strlen_zero(args->type)) { ast_ari_response_error( -- GitLab