From 4123b27f6f94921f506b964c5f62e2556d6e694b Mon Sep 17 00:00:00 2001 From: Matthew Jordan <mjordan@digium.com> Date: Fri, 5 Jul 2013 03:08:58 +0000 Subject: [PATCH] Remove parkinglot from the channel snapshot Legacy channel drivers often include the ability to set a default parking lot on an endpoint basis; when channels are created for that endpoint, they inherit the parkinglot option. Parking used to use this option more frequently; while it is still supported, other options (such as using channel variables or creation of a custom parkinglot) are supported. More importantly, conveying the parkinglot information through a channel snapshot isn't terribly useful - it is rarely (if ever) changed on a channel and some consumers of channel snapshots, such as ARI, will never use the information. (closes issue ASTERISK-21968) Reported by: Matt Jordan git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@393716 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- include/asterisk/stasis_channels.h | 1 - main/stasis_channels.c | 1 - 2 files changed, 2 deletions(-) diff --git a/include/asterisk/stasis_channels.h b/include/asterisk/stasis_channels.h index 24fe01ceab..90df75ec58 100644 --- a/include/asterisk/stasis_channels.h +++ b/include/asterisk/stasis_channels.h @@ -44,7 +44,6 @@ struct ast_channel_snapshot { AST_STRING_FIELD(userfield); /*!< Userfield for CEL billing */ AST_STRING_FIELD(uniqueid); /*!< Unique Channel Identifier */ AST_STRING_FIELD(linkedid); /*!< Linked Channel Identifier -- gets propagated by linkage */ - AST_STRING_FIELD(parkinglot); /*!< Default parking lot, if empty, default parking lot */ AST_STRING_FIELD(hangupsource); /*!< Who is responsible for hanging up this channel */ AST_STRING_FIELD(appl); /*!< Current application */ AST_STRING_FIELD(data); /*!< Data passed to current application */ diff --git a/main/stasis_channels.c b/main/stasis_channels.c index d121279d88..8cf259579b 100644 --- a/main/stasis_channels.c +++ b/main/stasis_channels.c @@ -145,7 +145,6 @@ struct ast_channel_snapshot *ast_channel_snapshot_create(struct ast_channel *cha ast_string_field_set(snapshot, userfield, ast_channel_userfield(chan)); ast_string_field_set(snapshot, uniqueid, ast_channel_uniqueid(chan)); ast_string_field_set(snapshot, linkedid, ast_channel_linkedid(chan)); - ast_string_field_set(snapshot, parkinglot, ast_channel_parkinglot(chan)); ast_string_field_set(snapshot, hangupsource, ast_channel_hangupsource(chan)); if (ast_channel_appl(chan)) { ast_string_field_set(snapshot, appl, ast_channel_appl(chan)); -- GitLab