From 45db91dd980d2dceac2dbde1cc6ab647ffbb078e Mon Sep 17 00:00:00 2001
From: Mark Michelson <mmichelson@digium.com>
Date: Mon, 9 Jun 2014 20:21:42 +0000
Subject: [PATCH] chan_pjsip: Fix bug where custom SIP headers could be
duplicated on outgoing INVITEs.
When using PJSIP_HEADER() to add custom headers to outgoing INVITE requests, certain
situations could result in the headers being duplicated. For instance, if the request
were retransmitted, or if the INVITE were re-sent with authentication credentials,
the custom headers would be re-added to the request.
The fix here is to, after adding the custom headers to the outbound INVITE, remove
the datastore that holds the custom headers to add. This way, there is no risk in
accidentally adding them if the session supplement is called into a second or third
time.
........
Merged revisions 415579 from http://svn.asterisk.org/svn/asterisk/branches/12
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@415580 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---
res/res_pjsip_header_funcs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/res/res_pjsip_header_funcs.c b/res/res_pjsip_header_funcs.c
index b5383fb324..dc9d6aad4f 100644
--- a/res/res_pjsip_header_funcs.c
+++ b/res/res_pjsip_header_funcs.c
@@ -592,6 +592,7 @@ static void outgoing_request(struct ast_sip_session *session, pjsip_tx_data * td
AST_LIST_TRAVERSE(list, le, nextptr) {
pjsip_msg_add_hdr(tdata->msg, (pjsip_hdr *) pjsip_hdr_clone(pool, le->hdr));
}
+ ast_sip_session_remove_datastore(session, datastore->uid);
}
static struct ast_sip_session_supplement header_funcs_supplement = {
--
GitLab