From 45edaa4c3a453424623676810fe7655983a66985 Mon Sep 17 00:00:00 2001
From: Luigi Rizzo <rizzo@icir.org>
Date: Tue, 28 Mar 2006 13:46:04 +0000
Subject: [PATCH] optimize a bit name completion by avoiding repeated calls to
strlen(word), localize variables and normalize the test for finding the
candidate string.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@15516 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---
channels/chan_agent.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/channels/chan_agent.c b/channels/chan_agent.c
index 9317aad894..d13b091fbb 100644
--- a/channels/chan_agent.c
+++ b/channels/chan_agent.c
@@ -1552,18 +1552,15 @@ static int action_agent_logoff(struct mansession *s, struct message *m)
static char *complete_agent_logoff_cmd(const char *line, const char *word, int pos, int state)
{
- struct agent_pvt *p;
- char name[AST_MAX_AGENT];
- int which = 0;
-
if (pos == 2) {
+ struct agent_pvt *p;
+ char name[AST_MAX_AGENT];
+ int which = 0, len = strlen(word);
+
AST_LIST_TRAVERSE(&agents, p, list) {
snprintf(name, sizeof(name), "Agent/%s", p->agent);
- if (!strncasecmp(word, name, strlen(word))) {
- if (++which > state) {
- return ast_strdup(name);
- }
- }
+ if (!strncasecmp(word, name, len) && ++which > state)
+ return ast_strdup(name);
}
} else if (pos == 3 && state == 0) {
return ast_strdup("soft");
--
GitLab