diff --git a/formats/format_pcm.c b/formats/format_pcm.c index 289038ced52c15e9c4a738514897f04a3c2df5b3..da72a559ecb48eed26c1bcc2b290f9da32bbbda5 100644 --- a/formats/format_pcm.c +++ b/formats/format_pcm.c @@ -177,6 +177,7 @@ static int pcm_write(struct ast_filestream *fs, struct ast_frame *f) static int pcm_seek(struct ast_filestream *fs, long sample_offset, int whence) { long cur, max, offset = 0; + int ret = -1; /* assume error */ cur = ftell(fs->f); fseek(fs->f, 0, SEEK_END); @@ -193,29 +194,33 @@ static int pcm_seek(struct ast_filestream *fs, long sample_offset, int whence) case SEEK_FORCECUR: offset = cur + sample_offset; break; + default: + ast_log(LOG_WARNING, "invalid whence %d, assuming SEEK_SET\n", whence); + offset = sample_offset; } - - switch (whence) { - case SEEK_FORCECUR: + if (offset < 0) { + ast_log(LOG_WARNING, "negative offset %ld, resetting to 0\n", offset); + offset = 0; + } + if (whence == SEEK_FORCECUR && offset > max) { /* extend the file */ + size_t left = offset - max; + + while (left) { + size_t written = fwrite(ulaw_silence, sizeof(ulaw_silence[0]), + (left > BUF_SIZE) ? BUF_SIZE : left, fs->f); + if (written == -1) + break; /* error */ + left -= written * sizeof(ulaw_silence[0]); + } + ret = 0; /* successful */ + } else { if (offset > max) { - size_t left = offset - max; - size_t res; - - while (left) { - res = fwrite(ulaw_silence, sizeof(ulaw_silence[0]), - (left > BUF_SIZE) ? BUF_SIZE : left, fs->f); - if (res == -1) - return res; - left -= res * sizeof(ulaw_silence[0]); - } - return offset; + ast_log(LOG_WARNING, "offset too large %ld, truncating to %ld\n", offset, max); + offset = max; } - /* fall through */ - default: - offset = (offset > max) ? max : offset; - offset = (offset < 0) ? 0 : offset; - return fseek(fs->f, offset, SEEK_SET); + ret = fseek(fs->f, offset, SEEK_SET); } + return ret; } static int pcm_trunc(struct ast_filestream *fs) diff --git a/formats/format_pcm_alaw.c b/formats/format_pcm_alaw.c index 13d7c174a8937554edeacb5db7134428e2b9c8ed..ffbb17a4fe571860bd367677ff603b490e2bff62 100644 --- a/formats/format_pcm_alaw.c +++ b/formats/format_pcm_alaw.c @@ -252,6 +252,7 @@ static int pcm_write(struct ast_filestream *fs, struct ast_frame *f) static int pcm_seek(struct ast_filestream *fs, long sample_offset, int whence) { long cur, max, offset = 0; + int ret = -1; /* assume error */ cur = ftell(fs->f); fseek(fs->f, 0, SEEK_END); @@ -268,29 +269,34 @@ static int pcm_seek(struct ast_filestream *fs, long sample_offset, int whence) case SEEK_FORCECUR: offset = cur + sample_offset; break; + default: + ast_log(LOG_WARNING, "invalid whence %d, assuming SEEK_SET\n", whence); + offset = sample_offset; } - switch (whence) { - case SEEK_FORCECUR: - if (offset > max) { - size_t left = offset - max; - size_t res; - - while (left) { - res = fwrite(alaw_silence, sizeof(alaw_silence[0]), - (left > BUF_SIZE) ? BUF_SIZE : left, fs->f); - if (res == -1) - return res; - left -= res * sizeof(alaw_silence[0]); - } - return offset; + if (offset < 0) { + offset = 0; + ast_log(LOG_WARNING, "negative offset %ld, resetting to 0\n", offset); + } + if (whence == SEEK_FORCECUR && offset > max) { + size_t left = offset - max; + + while (left) { + size_t written = fwrite(alaw_silence, sizeof(alaw_silence[0]), + (left > BUF_SIZE) ? BUF_SIZE : left, fs->f); + if (written == -1) + break; /* error */ + left -= written * sizeof(alaw_silence[0]); } - /* fall through */ - default: - offset = (offset > max) ? max : offset; - offset = (offset < 0) ? 0 : offset; - return fseek(fs->f, offset, SEEK_SET); + ret = 0; /* success */ + } else { + if (offset > max) { + ast_log(LOG_WARNING, "offset too large %ld, truncating to %ld\n", offset, max); + offset = max; + } + ret = fseek(fs->f, offset, SEEK_SET); } + return ret; } static int pcm_trunc(struct ast_filestream *fs)