From 5333a48b17e3f0f9cb12a7cb23da9bc509539dd7 Mon Sep 17 00:00:00 2001
From: Richard Mudgett <rmudgett@digium.com>
Date: Sat, 3 Apr 2010 01:42:32 +0000
Subject: [PATCH] Using the Dial application f option when the call is
 forwarded will likely crash.

Fix app_dial.c:do_forward() OPT_FORCECLID setting cid.cid_num with a stack
allocated string instead of a heap allocated string.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@256103 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---
 apps/app_dial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/app_dial.c b/apps/app_dial.c
index 612efcc649..d4b16a36b2 100644
--- a/apps/app_dial.c
+++ b/apps/app_dial.c
@@ -835,7 +835,7 @@ static void do_forward(struct chanlist *o,
 		c->cid.cid_tns = in->cid.cid_tns;
 
 		if (ast_test_flag64(o, OPT_FORCECLID)) {
-			S_REPLACE(c->cid.cid_num, ast_strdupa(S_OR(in->macroexten, in->exten)));
+			S_REPLACE(c->cid.cid_num, ast_strdup(S_OR(in->macroexten, in->exten)));
 			S_REPLACE(c->cid.cid_name, NULL);
 			ast_string_field_set(c, accountcode, c->accountcode);
 		} else {
-- 
GitLab