From a0b9439beee6457dd2177072c0dc0959e18345cd Mon Sep 17 00:00:00 2001 From: Olle Johansson <oej@edvina.net> Date: Tue, 4 Apr 2006 07:59:02 +0000 Subject: [PATCH] Clarify syntax of new manager events that reports a status. We do not longer approve "ThisEventOn" and "ThisEventOff" named events, they need to be named "ThisEvent" with a status header showing the current status. (Approved by Mark) Old events won't be changed to keep backwards compatibility, until we have a revision plan for the AMI. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17199 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- doc/CODING-GUIDELINES | 13 +++++++++++++ doc/manager.txt | 1 + 2 files changed, 14 insertions(+) diff --git a/doc/CODING-GUIDELINES b/doc/CODING-GUIDELINES index c8afc704e7..a19fd0ad07 100644 --- a/doc/CODING-GUIDELINES +++ b/doc/CODING-GUIDELINES @@ -522,6 +522,19 @@ int len = 0; if (name && (len = strlen(name) + strlen(prefix) + strlen(postfix) + 3) && (newname = alloca(len))) snprintf(newname, len, "%s/%s/%s", prefix, name, postfix); +* Creating new manager events? +------------------------------ +If you create new AMI events, please read manager.txt. Do not re-use +existing headers for new purposes, but please re-use existing headers +for the same type of data. + +Manager events that signal a status are required to have one +event name, with a status header that shows the status. +The old style, with one event named "ThisEventOn" and another named +"ThisEventOff", is no longer approved. + +Check manager.txt for more information on manager and existing +headers. Please update this file if you add new headers. ----------------------------------------------- Welcome to the Asterisk development community! diff --git a/doc/manager.txt b/doc/manager.txt index 065d70a214..cee0c470a9 100644 --- a/doc/manager.txt +++ b/doc/manager.txt @@ -296,3 +296,4 @@ Some standard AMI headers: ** Please try to re-use existing headers to simplify manager message parsing in clients. +Read the CODING-GUIDELINES if you develop new manager commands or events. -- GitLab