diff --git a/UPGRADE.txt b/UPGRADE.txt index ce548d083b090517249cd33ffcde286f1ae1c598..b1c63b9cdc951e48c8c043c7fb490c297911543b 100644 --- a/UPGRADE.txt +++ b/UPGRADE.txt @@ -20,6 +20,18 @@ === =========================================================== +from 11.6-cert6 to 11.6-cert7: + +* Due to the POODLE vulnerability (see + https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2014-3566), the + default TLS method for TLS clients will no longer allow SSLv3. As + SSLv2 was already deprecated, it is no longer allowed by default as + well. TLS servers no longer allow SSLv2 or SSLv3 connections. This + affects the chan_sip channel driver, AMI, and the Asterisk HTTP server. + +* The res_jabber resource module no longer uses SSLv3 to connect to an + XMPP server. It will now only use TLSv1 or later methods. + From 11.6-cert2 to 11.6-cert3: * MixMonitor AMI actions now require users to have authorization classes. * MixMonitor - system diff --git a/main/tcptls.c b/main/tcptls.c index 65101f4c9c80fcd5f1923c8588294a2cdb87b990..27e0113c3e3443f512fed0c9eb1ffba733a87a53 100644 --- a/main/tcptls.c +++ b/main/tcptls.c @@ -741,6 +741,8 @@ static int __ssl_setup(struct ast_tls_config *cfg, int client) cfg->enabled = 0; return 0; #else + int disable_ssl = 0; + if (!cfg->enabled) { return 0; } @@ -756,22 +758,21 @@ static int __ssl_setup(struct ast_tls_config *cfg, int client) if (client) { #ifndef OPENSSL_NO_SSL2 if (ast_test_flag(&cfg->flags, AST_SSL_SSLV2_CLIENT)) { + ast_log(LOG_WARNING, "Usage of SSLv2 is discouraged due to known vulnerabilities. Please use 'tlsv1' or leave the TLS method unspecified!\n"); cfg->ssl_ctx = SSL_CTX_new(SSLv2_client_method()); } else #endif if (ast_test_flag(&cfg->flags, AST_SSL_SSLV3_CLIENT)) { + ast_log(LOG_WARNING, "Usage of SSLv3 is discouraged due to known vulnerabilities. Please use 'tlsv1' or leave the TLS method unspecified!\n"); cfg->ssl_ctx = SSL_CTX_new(SSLv3_client_method()); } else if (ast_test_flag(&cfg->flags, AST_SSL_TLSV1_CLIENT)) { cfg->ssl_ctx = SSL_CTX_new(TLSv1_client_method()); } else { - /* SSLv23_client_method() sends SSLv2, this was the original - * default for ssl clients before the option was given to - * pick what protocol a client should use. In order not - * to break expected behavior it remains the default. */ + disable_ssl = 1; cfg->ssl_ctx = SSL_CTX_new(SSLv23_client_method()); } } else { - /* SSLv23_server_method() supports TLSv1, SSLv2, and SSLv3 inbound connections. */ + disable_ssl = 1; cfg->ssl_ctx = SSL_CTX_new(SSLv23_server_method()); } @@ -781,6 +782,17 @@ static int __ssl_setup(struct ast_tls_config *cfg, int client) return 0; } + /* Due to the POODLE vulnerability, completely disable + * SSLv2 and SSLv3 if we are not explicitly told to use + * them. SSLv23_*_method supports TLSv1+. + */ + if (disable_ssl) { + long ssl_opts; + + ssl_opts = SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3; + SSL_CTX_set_options(cfg->ssl_ctx, ssl_opts); + } + SSL_CTX_set_verify(cfg->ssl_ctx, ast_test_flag(&cfg->flags, AST_SSL_VERIFY_CLIENT) ? SSL_VERIFY_PEER | SSL_VERIFY_FAIL_IF_NO_PEER_CERT : SSL_VERIFY_NONE, NULL); diff --git a/res/res_jabber.c b/res/res_jabber.c index b7c62cbb2c70b36df006e09272334b172278ce26..667b79d89d38bbff589c4d5b99c2db8c5ecaa6b2 100644 --- a/res/res_jabber.c +++ b/res/res_jabber.c @@ -1282,14 +1282,17 @@ static int aji_start_tls(struct aji_client *client) static int aji_tls_handshake(struct aji_client *client) { int sock; + long ssl_opts; ast_debug(1, "Starting TLS handshake\n"); /* Choose an SSL/TLS protocol version, create SSL_CTX */ - client->ssl_method = SSLv3_method(); + client->ssl_method = SSLv23_method(); if (!(client->ssl_context = SSL_CTX_new((SSL_METHOD *) client->ssl_method))) { return IKS_NET_TLSFAIL; } + ssl_opts = SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3; + SSL_CTX_set_options(client->ssl_context, ssl_opts); /* Create new SSL session */ if (!(client->ssl_session = SSL_new(client->ssl_context))) { diff --git a/res/res_xmpp.c b/res/res_xmpp.c index 3425be620ae81623e320398338a2ca99d28d512f..af1c7454ac40f5a506b0b63c74ea8a15498e6873 100644 --- a/res/res_xmpp.c +++ b/res/res_xmpp.c @@ -2501,6 +2501,7 @@ static int xmpp_client_requested_tls(struct ast_xmpp_client *client, struct ast_ { #ifdef HAVE_OPENSSL int sock; + long ssl_opts; #endif if (!strcmp(iks_name(node), "success")) { @@ -2519,11 +2520,14 @@ static int xmpp_client_requested_tls(struct ast_xmpp_client *client, struct ast_ ast_log(LOG_ERROR, "Somehow we managed to try to start TLS negotiation on client '%s' without OpenSSL support, disconnecting\n", client->name); return -1; #else - client->ssl_method = SSLv3_method(); + client->ssl_method = SSLv23_method(); if (!(client->ssl_context = SSL_CTX_new((SSL_METHOD *) client->ssl_method))) { goto failure; } + ssl_opts = SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3; + SSL_CTX_set_options(client->ssl_context, ssl_opts); + if (!(client->ssl_session = SSL_new(client->ssl_context))) { goto failure; }