From aac442eecdf5c2609eef96d84175c2e4c5e81eae Mon Sep 17 00:00:00 2001
From: Sean Bright <sean.bright@gmail.com>
Date: Tue, 23 Mar 2021 16:15:45 -0400
Subject: [PATCH] app_queue.c: Remove dead 'updatecdr' code.
Also removed the sample documentation, and some oddly-placed
documentation about the timeout argument to the Queue() application
itself. There is a large section on the timeout behavior below.
ASTERISK-26614 #close
Change-Id: I8f84e8304b50305b7c4cba2d9787a5d77c3a6217
---
apps/app_queue.c | 7 -------
configs/samples/queues.conf.sample | 13 -------------
2 files changed, 20 deletions(-)
diff --git a/apps/app_queue.c b/apps/app_queue.c
index 153fe6b0c3..d3e04713b6 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -1483,9 +1483,6 @@ static int realtime_rules;
/*! \brief Subscription to device state change messages */
static struct stasis_subscription *device_state_sub;
-/*! \brief queues.conf [general] option */
-static int update_cdr;
-
/*! \brief queues.conf [general] option */
static int negative_penalty_invalid;
@@ -9206,7 +9203,6 @@ static void queue_reset_global_params(void)
queue_persistent_members = 0;
autofill_default = 0;
montype_default = 0;
- update_cdr = 0;
shared_lastcall = 0;
negative_penalty_invalid = 0;
log_membername_as_agent = 0;
@@ -9226,9 +9222,6 @@ static void queue_set_global_params(struct ast_config *cfg)
if (!strcasecmp(general_val, "mixmonitor"))
montype_default = 1;
}
- if ((general_val = ast_variable_retrieve(cfg, "general", "updatecdr"))) {
- update_cdr = ast_true(general_val);
- }
if ((general_val = ast_variable_retrieve(cfg, "general", "shared_lastcall"))) {
shared_lastcall = ast_true(general_val);
}
diff --git a/configs/samples/queues.conf.sample b/configs/samples/queues.conf.sample
index 69e5975387..a58f77c933 100644
--- a/configs/samples/queues.conf.sample
+++ b/configs/samples/queues.conf.sample
@@ -41,19 +41,6 @@ persistentmembers = yes
;
monitor-type = MixMonitor
;
-; UpdateCDR behavior.
-; This option is implemented to mimic chan_agents behavior of populating
-; CDR dstchannel field of a call with an agent name, which you can set
-; at the login time with AddQueueMember membername parameter.
-;
-; updatecdr = no
-
-;
-; Note that a timeout to fail out of a queue may be passed as part of
-; an application call from extensions.conf:
-; Queue(queuename,[options],[optionalurl],[announceoverride],[timeout])
-; example: Queue(dave,t,,,45)
-
; shared_lastcall will make the lastcall and calls received be the same in
; members logged in more than one queue. This is useful to make the queue
; respect the wrapuptime of another queue for a shared member.
--
GitLab