From b0863c5e31f6e96add76b383ae3f08b655715e33 Mon Sep 17 00:00:00 2001
From: Mark Spencer <markster@digium.com>
Date: Wed, 16 Feb 2005 03:46:00 +0000
Subject: [PATCH] Optimize vm storage (bug #3605)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5035 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---
apps/app_voicemail.c | 22 ++++++----------------
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index d39fbbd66c..07099e1da7 100755
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -743,23 +743,15 @@ static int retrieve_file(char *dir, int msgnum)
goto yuck;
}
if (!strcmp(coltitle, "recording")) {
+ res = SQLGetData(stmt, x + 1, SQL_BINARY, NULL, 0, &colsize);
fdlen = colsize;
fd = open(full_fn, O_RDWR | O_TRUNC | O_CREAT, 0770);
if (fd > -1) {
- /* Ugh, gotta fill it so we can mmap */
- char tmp[1024]="";
- size_t left = 0, bytes = 0;
- left = fdlen;
- while(left) {
- bytes = left;
- if (bytes > sizeof(tmp))
- bytes = sizeof(tmp);
- if (write(fd, tmp, bytes) != bytes) {
- close(fd);
- fd = -1;
- break;
- }
- left -= bytes;
+ char tmp[1]="";
+ lseek(fd, fdlen - 1, SEEK_SET);
+ if (write(fd, tmp, 1) != 1) {
+ close(fd);
+ fd = -1;
}
if (fd > -1)
fdm = mmap(NULL, fdlen, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
@@ -772,8 +764,6 @@ static int retrieve_file(char *dir, int msgnum)
SQLFreeHandle (SQL_HANDLE_STMT, stmt);
goto yuck;
}
- fdlen = colsize;
- ftruncate(fd, fdlen);
}
} else {
res = SQLGetData(stmt, x + 1, SQL_CHAR, rowdata, sizeof(rowdata), NULL);
--
GitLab