From c7a5a96fc6f08ecffa692407f14218c7bb5d74b3 Mon Sep 17 00:00:00 2001 From: Luigi Rizzo <rizzo@icir.org> Date: Sat, 3 Jun 2006 22:18:41 +0000 Subject: [PATCH] mark XXX a bug in the code. oej/kevin, any idea what you want to use here ? git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@31841 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- channels/chan_sip.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 81f3ccb657..0b657f68aa 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -7331,6 +7331,10 @@ static int get_refer_info(struct sip_pvt *transferer, struct sip_request *outgoi if ((ptr = strchr(referdata->replaces_callid, ';'))) /* Remove options */ { *ptr = '\0'; } + /* + * XXX don't know what was the intention but this code is + * definitely wrong, as ptr can be NULL here. + */ ptr++; /* Find the different tags before we destroy the string */ -- GitLab