From c9aa3b01690aa68a8c38cc31056e7b5e98dd4fd3 Mon Sep 17 00:00:00 2001 From: Naveen Albert <asterisk@phreaknet.org> Date: Tue, 28 Mar 2023 13:37:55 +0000 Subject: [PATCH] voicemail.conf: Fix incorrect comment about #include. A comment at the top of voicemail.conf says that #include cannot be used in voicemail.conf because this breaks the ability for app_voicemail to auto-update passwords. This is factually incorrect, since Asterisk has no problem updating files that are #include'd in the main configuration file, and this does work in voicemail.conf as well. ASTERISK-30479 #close Change-Id: I3bf7d275849ab83f55f7fb6702a75a3077ee1df3 (cherry picked from commit d0f39250eeb7e62496477fd4cf57827eb9a99624) --- configs/samples/voicemail.conf.sample | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/configs/samples/voicemail.conf.sample b/configs/samples/voicemail.conf.sample index e799cf602b..8771bea1e0 100644 --- a/configs/samples/voicemail.conf.sample +++ b/configs/samples/voicemail.conf.sample @@ -4,10 +4,14 @@ ; ********* NOTICE ************************************************************ ; -; NOTE: Asterisk has to edit this file to change a user's password. This does -; not currently work with the "#include <file>" directive for Asterisk -; configuration files, nor when using realtime static configuration. -; Do not use them with this configuration file. +; NOTE: Asterisk has to edit this file to change a user's password, so +; do not use realtime static configuration with this file. +; To avoid requiring config updates on password updates, you could use the +; passwordlocation option to store passwords separately. +; +; If your "source of truth" for voicemail passwords is elsewhere, you should +; use the externpassnotify option to notify whatever stores the passwords +; (e.g. external database) when there are changes, to keep it synchronized. ; ; NOTE: Mailboxes defined by app_voicemail MUST be referenced by the rest ; of the system as mailbox@context. The rest of the system cannot add -- GitLab