diff --git a/bridges/bridge_softmix.c b/bridges/bridge_softmix.c index 46b27f104206ca0053324c8c5d558dd5e842856b..249985a53b0a00b713b8d7c6d18f231714d1bc24 100644 --- a/bridges/bridge_softmix.c +++ b/bridges/bridge_softmix.c @@ -2085,7 +2085,9 @@ static void remb_enable_collection(struct ast_bridge *bridge, struct ast_bridge_ } } - if (AST_VECTOR_REPLACE(&softmix_data->remb_collectors, bridge_stream_position, ao2_bump(sc->remb_collector))) { + ao2_ref(sc->remb_collector, +1); + if (AST_VECTOR_REPLACE(&softmix_data->remb_collectors, bridge_stream_position, + sc->remb_collector)) { ao2_ref(sc->remb_collector, -1); } } diff --git a/res/res_pjsip/pjsip_options.c b/res/res_pjsip/pjsip_options.c index 579f70e02d0749171413b49dd86e790aae21287f..5eaf9e8fd4c62a2cde164ef7902d9857ec99adc1 100644 --- a/res/res_pjsip/pjsip_options.c +++ b/res/res_pjsip/pjsip_options.c @@ -1530,10 +1530,11 @@ static int sip_options_endpoint_compositor_add_task(void *obj) ast_debug(3, "Adding endpoint compositor '%s' to AOR '%s'\n", task_data->endpoint_state_compositor->name, task_data->aor_options->name); + ao2_ref(task_data->endpoint_state_compositor, +1); if (AST_VECTOR_APPEND(&task_data->aor_options->compositors, - ao2_bump(task_data->endpoint_state_compositor))) { + task_data->endpoint_state_compositor)) { /* Failed to add so no need to update the endpoint status. Nothing changed. */ - ao2_cleanup(task_data->endpoint_state_compositor); + ao2_ref(task_data->endpoint_state_compositor, -1); return 0; } diff --git a/res/res_pjsip_history.c b/res/res_pjsip_history.c index eed06eed8238f6fb3d3fb6fe414a496a1cd54bf5..10bcd961877401423557e3b46af8e4bc1f03c7af 100644 --- a/res/res_pjsip_history.c +++ b/res/res_pjsip_history.c @@ -1133,7 +1133,8 @@ static struct vector_history_t *filter_history(struct ast_cli_args *a) } else if (!res) { continue; } else { - if (AST_VECTOR_APPEND(output, ao2_bump(entry))) { + ao2_bump(entry); + if (AST_VECTOR_APPEND(output, entry)) { ao2_cleanup(entry); } } diff --git a/res/res_pjsip_session.c b/res/res_pjsip_session.c index 49ab8756829f95dcd4dbddaa271dc785ad586b19..8b1012e5e005e7c0c638cc34656380c04a498423 100644 --- a/res/res_pjsip_session.c +++ b/res/res_pjsip_session.c @@ -250,7 +250,10 @@ struct ast_sip_session_media_state *ast_sip_session_media_state_clone(const stru struct ast_sip_session_media *session_media = AST_VECTOR_GET(&media_state->sessions, index); enum ast_media_type type = ast_stream_get_type(ast_stream_topology_get_stream(cloned->topology, index)); - AST_VECTOR_REPLACE(&cloned->sessions, index, ao2_bump(session_media)); + ao2_bump(session_media); + if (AST_VECTOR_REPLACE(&cloned->sessions, index, session_media)) { + ao2_cleanup(session_media); + } if (ast_stream_get_state(ast_stream_topology_get_stream(cloned->topology, index)) != AST_STREAM_STATE_REMOVED && !cloned->default_session[type]) { cloned->default_session[type] = session_media; diff --git a/res/stasis/messaging.c b/res/stasis/messaging.c index 77a58745a18539ce11af8e817bd060fa4f5cbdef..a7716b8043f6e44c05b915649162dbba1cdbca16 100644 --- a/res/stasis/messaging.c +++ b/res/stasis/messaging.c @@ -457,8 +457,9 @@ static struct message_subscription *get_or_create_subscription(struct ast_endpoi ao2_link(endpoint_subscriptions, sub); } else { ast_rwlock_wrlock(&tech_subscriptions_lock); - if (AST_VECTOR_APPEND(&tech_subscriptions, ao2_bump(sub))) { - /* Release the ao2_bump that was for the vector and allocation references. */ + ao2_ref(sub, +1); + if (AST_VECTOR_APPEND(&tech_subscriptions, sub)) { + /* Release the refs that were for the vector and the allocation. */ ao2_ref(sub, -2); sub = NULL; }