diff --git a/CHANGES b/CHANGES index 6b6720a5d19f032d094db3d6558753c8af0e45ae..f860225460893f2311d0aa2645f859044b2c2c9c 100644 --- a/CHANGES +++ b/CHANGES @@ -8,6 +8,17 @@ === ============================================================================== +------------------------------------------------------------------------------ +--- Functionality changes from Asterisk 10 to Asterisk 11 -------------------- +------------------------------------------------------------------------------ + +SIP Changes +----------- + * Asterisk will no longer substitute CID number for CID name into display + name field if CID number exists without a CID name. This change improves + compatibility with certain device features such as Avaya IP500's directory + lookup service. + ------------------------------------------------------------------------------ --- Functionality changes from Asterisk 1.8 to Asterisk 10 ------------------- ------------------------------------------------------------------------------ diff --git a/channels/chan_sip.c b/channels/chan_sip.c index ed0e3bb651bc0b1196438dc8eda83b5261e768b9..0223f1377298e3fc0f5392da26c0701ebe35ddda 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -11792,6 +11792,8 @@ static void initreqprep(struct sip_request *req, struct sip_pvt *p, int sipmetho const char *d = NULL; /* domain in from header */ const char *urioptions = ""; int ourport; + int cid_has_name = 1; + int cid_has_num = 1; if (ast_test_flag(&p->flags[0], SIP_USEREQPHONE)) { const char *s = p->username; /* being a string field, cannot be NULL */ @@ -11838,10 +11840,15 @@ static void initreqprep(struct sip_request *req, struct sip_pvt *p, int sipmetho l = p->mwi_from; } - if (ast_strlen_zero(l)) + if (ast_strlen_zero(l)) { + cid_has_num = 0; l = default_callerid; - if (ast_strlen_zero(n)) + } + if (ast_strlen_zero(n)) { + cid_has_name = 0; n = l; + } + /* Allow user to be overridden */ if (!ast_strlen_zero(p->fromuser)) l = p->fromuser; @@ -11862,10 +11869,20 @@ static void initreqprep(struct sip_request *req, struct sip_pvt *p, int sipmetho } ourport = (p->fromdomainport) ? p->fromdomainport : ast_sockaddr_port(&p->ourip); + + /* If a caller id name was specified, add a display name. */ + if (cid_has_name || !cid_has_num) { + snprintf(from, sizeof(from), "\"%s\" ", n); + } else { + from[0] = '\0'; + } + if (!sip_standard_port(p->socket.type, ourport)) { - snprintf(from, sizeof(from), "\"%s\" <sip:%s@%s:%d>;tag=%s", n, l, d, ourport, p->tag); + size_t offset = strlen(from); + snprintf(&from[offset], sizeof(from) - offset, "<sip:%s@%s:%d>;tag=%s", l, d, ourport, p->tag); } else { - snprintf(from, sizeof(from), "\"%s\" <sip:%s@%s>;tag=%s", n, l, d, p->tag); + size_t offset = strlen(from); + snprintf(&from[offset], sizeof(from) - offset, "<sip:%s@%s>;tag=%s", l, d, p->tag); } if (!ast_strlen_zero(explicit_uri)) {