From fbb19db0c83e6f9d1e7c557dc60adfa7cdf84e25 Mon Sep 17 00:00:00 2001
From: Corey Farrell <git@cfware.com>
Date: Tue, 14 Oct 2014 16:47:02 +0000
Subject: [PATCH] res_fax: Fix reference leak caused by gateway sessions
Fax gateway session objects can be re-used, causing the
same gateway session to be added to faxregistry.container
more than once. This change causes fax_session_new to
remove the reserved session from the container before
it's id is changed, ensuring it's possible for the
session to be freed.
ASTERISK-24392 #close
Reported by: Corey Farrell
Review: https://reviewboard.asterisk.org/r/4049/
........
Merged revisions 425457 from http://svn.asterisk.org/svn/asterisk/branches/11
........
Merged revisions 425458 from http://svn.asterisk.org/svn/asterisk/branches/12
........
Merged revisions 425459 from http://svn.asterisk.org/svn/asterisk/branches/13
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@425460 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---
res/res_fax.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/res/res_fax.c b/res/res_fax.c
index aef6360ff0..01228c1754 100644
--- a/res/res_fax.c
+++ b/res/res_fax.c
@@ -1216,6 +1216,7 @@ static struct ast_fax_session *fax_session_new(struct ast_fax_session_details *d
if (reserved) {
s = reserved;
ao2_ref(reserved, +1);
+ ao2_unlink(faxregistry.container, reserved);
/* NOTE: we don't consume the reference to the reserved
* session. The session returned from fax_session_new() is a
--
GitLab