From ff9ab3857392ea58624e2f40b8a5c35e4224ced6 Mon Sep 17 00:00:00 2001 From: George Joseph <gjoseph@digium.com> Date: Fri, 23 Dec 2022 05:02:43 -0700 Subject: [PATCH] res_pjsip_transport_websocket: Add remote port to transport When Asterisk receives a new websocket conenction, it creates a new pjsip transport for it and copies connection data into it. The transport manager then uses the remote IP address and port on the transport to create a monitor for each connection. However, the remote port wasn't being copied, only the IP address which meant that the transport manager was creating only 1 monitoring entry for all websocket connections from the same IP address. Therefore, if one of those connections failed, it deleted the transport taking all the the connections from that same IP address with it. * We now copy the remote port into the created transport and the transport manager behaves correctly. ASTERISK-30369 Change-Id: Ib506d40897ea6286455ac0be4dfbb0ed43b727e1 (cherry picked from commit 24102ba236253735b667ee98fa82d1198d294d56) --- res/res_pjsip_transport_websocket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/res/res_pjsip_transport_websocket.c b/res/res_pjsip_transport_websocket.c index e6ae100cca..3772097d3d 100644 --- a/res/res_pjsip_transport_websocket.c +++ b/res/res_pjsip_transport_websocket.c @@ -226,6 +226,7 @@ static int transport_create(void *data) pj_strdup2(pool, &newtransport->transport.local_name.host, ast_sockaddr_stringify_addr(ast_websocket_local_address(newtransport->ws_session))); newtransport->transport.local_name.port = ast_sockaddr_port(ast_websocket_local_address(newtransport->ws_session)); pj_strdup2(pool, &newtransport->transport.remote_name.host, ast_sockaddr_stringify_addr(ast_websocket_remote_address(newtransport->ws_session))); + newtransport->transport.remote_name.port = ast_sockaddr_port(ast_websocket_remote_address(newtransport->ws_session)); newtransport->transport.flag = pjsip_transport_get_flag_from_type((pjsip_transport_type_e)newtransport->transport.key.type); newtransport->transport.dir = PJSIP_TP_DIR_INCOMING; -- GitLab