From df12c351a79cdd8bdda3eb3a5ff1c4c8da0ce898 Mon Sep 17 00:00:00 2001
From: Yalu Zhang <yalu.zhang@iopsys.eu>
Date: Thu, 9 Nov 2023 12:05:55 +0100
Subject: [PATCH] Fix a bug that always caused ubus call release from dectmngr
 replying error

Each time when dectmngr releases a call via ubus, an error reply is received like below.
{
	"terminal": 1,
	"pcm": 0,
	"errno": 1
}
Command failed: Unknown error

This doesn't cause any functional loss since dectmngr doesn't check the ubus reply from
voicemngr. But it is still misleading, especially when the ubus call is invoked manually
for debug and test purpose.
---
 line.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/line.c b/line.c
index 84841ad..08db84d 100644
--- a/line.c
+++ b/line.c
@@ -683,7 +683,8 @@ int line_close_connection_by_dect(int line, int pcm, struct voice_ubus_req_t *ub
 			}
 		}
 		voice_line_simulate_hook(line, VOICE_EVT_ONHOOK);
-		return -1;
+		return send_reply_dectmngr(ubus_req, line + 1, // +1 Dectmngr lines starting from 1
+			pcm, UBUS_STATUS_OK);
 	}
 
 	if(pcm == CALL_DEFAULT0 || pcm == CALL_DEFAULT1)
-- 
GitLab