Skip to content

bbf: TR181 Port Mapping "Enable" parameter updates correctly

sandeep sharma requested to merge Bug_8205 into devel

In order to set the value of "Device.NAT.PortMapping.1.Enable" parameter to 1 , there is a dependency on a parameter "src" to be available in the uci firewall config.

But the "src" parameter only appears when a parameter "Device.NAT.PortMapping.1.AllInterfaces" is set to 1.

So in the absence of "src" parameter , the value of parameter "Device.NAT.PortMapping.1.Enable" is not updated.

The sole purpose of fetching the value of "src" parameter is to check if for a particular zone lan/wan , what is the value of "masq" parameter .

As at the end in the code we do a " masq && (value of enable parameter) " condition check and then update the result as the value of "enable" parameter.

So basically we cant update the value of "enable" parameter before updating the value of "allinterface" parameter.

To avoid this , the condition check has been deleted now .

Merge request reports