Skip to content
Snippets Groups Projects
Commit 019b8fd0 authored by Sebastian Kemper's avatar Sebastian Kemper
Browse files

subversion: fix build failure

Since commit a62c0e59 apu-1-config is no longer being stipped down with
regards to being called with "--link-libtool". Example:

 $ ./staging_dir/target-mips_24kc_musl/usr/bin/apu-1-config --link-libtool
 -L/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/lib -R/home/sk/tmp/openwrt/staging_dir/target-mips_24kc_musl/usr/lib -laprutil-1
 $

Before the mentioned commit the "-R" argument was stripped off. And when the
Makefile adds this to TARGET_LDFLAGS this then ends up in the compiler test, as
an argument for the compiler, causing build failure:

checking whether the C compiler works... no
configure: error: in `/builder/shared-workdir/build/sdk/build_dir/target-arm_mpcore+vfp_musl_eabi/subversion-1.13.0':
configure: error: C compiler cannot create executables

config.log shows what's wrong:

configure:3140: x86_64-openwrt-linux-musl-gcc -Os -pipe ... <snip> ... -R/home/sk/tmp/sdk/master-x86-64/staging_dir/target-x86_64_musl/usr/lib -laprutil-1     conftest.c  >&5
x86_64-openwrt-linux-musl-gcc: error: unrecognized command line option '-R'

This commit does away with these flags, they're not needed anyway. FPIC
is also removed, because it's detrimental to the applications [1] and
unnecessary as well.

Fixes: #11139

[1] https://wiki.gentoo.org/wiki/Project:Hardened/Position_Independent_Code_internals



Signed-off-by: default avatarSebastian Kemper <sebastian_ml@gmx.net>
parent 8b238c84
No related branches found
No related tags found
No related merge requests found
......@@ -6,7 +6,7 @@
include $(TOPDIR)/rules.mk
PKG_NAME:=subversion
PKG_RELEASE:=1
PKG_RELEASE:=2
PKG_VERSION:=1.12.2
PKG_SOURCE_URL:=@APACHE/subversion
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2
......@@ -78,10 +78,6 @@ define Package/subversion-server/conffiles
/etc/config/subversion
endef
TARGET_CFLAGS += $(FPIC)
APU_LIBS=$(shell $(STAGING_DIR)/usr/bin/apu-1-config --link-libtool --libs)
TARGET_LDFLAGS += $(APU_LIBS)
CONFIGURE_ARGS += \
--with-apr="$(STAGING_DIR)/usr/bin/apr-1-config" \
--with-apr-util="$(STAGING_DIR)/usr/bin/apu-1-config" \
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment