fix possible vulnerabilities due to the use of eval

net/asterisk/files/iopsys/lib/voice/config_asterisk.sh

@@ -1137,56 +1137,56 @@ get_prefixinfo() {
 	config_get prefix $info prefixrange
 
 	[ "$type" = "EMERGENCY" ] && {
-		[ "$action" = "EMERGENCY" ] && echo emergency="$prefix"
+		[ "$action" = "EMERGENCY" ] && emergency="$prefix"
 		return
 	}
 
 	[ "$type" = "FAC" ] || return
 
-	echo channel_fac=\"\$channel_fac $prefix\"
+	channel_fac="${channel_fac:+${channel_fac} }$prefix"
 
 	case $action in
 	CFU_ACTIVATE)
-		echo cfim_on="$prefix"
+		cfim_on="$prefix"
 		;;
 	CFU_DEACTIVATE)
-		echo cfim_off="$prefix"
+		cfim_off="$prefix"
 		;;
 	CFNR_ACTIVATE)
-		echo cfbs_on="$prefix"
+		cfbs_on="$prefix"
 		;;
 	CFNR_DEACTIVATE)
-		echo cfbs_off="$prefix"
+		cfbs_off="$prefix"
 		;;
 	CFB_ACTIVATE)
-		echo cfb_on="$prefix"
+		cfb_on="$prefix"
 		;;
 	CFB_DEACTIVATE)
-		echo cfb_off="$prefix"
+		cfb_off="$prefix"
 		;;
 	CW_ACTIVATE)
-		echo cw_on="$prefix"
+		cw_on="$prefix"
 		;;
 	CW_DEACTIVATE)
-		echo cw_off="$prefix"
+		cw_off="$prefix"
 		;;
 	DND_ACTIVATE)
-		echo dnd_on="$prefix"
+		dnd_on="$prefix"
 		;;
 	DND_DEACTIVATE)
-		echo dnd_off="$prefix"
+		dnd_off="$prefix"
 		;;
 	DND_INTERROGATE)
-		echo dnd_status="$prefix"
+		dnd_status="$prefix"
 		;;
 	CW_STATUS)
-		echo cw_status="$prefix"
+		cw_status="$prefix"
 		;;
 	REDIAL)
-		echo redial="$prefix"
+		redial="$prefix"
 		;;
 	CALLRETURN)
-		echo call_return="$prefix"
+		call_return="$prefix"
 		;;
 	esac
 }
@@ -1254,7 +1254,7 @@ configure_feature_set() {
 
                 # load featurecodes from prefixinfo
                 local channel_fac
-                eval "$(config_foreach get_prefixinfo prefixinfo "FAC")"
+                config_foreach get_prefixinfo prefixinfo "FAC"
 
                 # Convert whitespace to commas
                 channel_fac=$(echo "$channel_fac" | tr -s ' ' ',')
@@ -1932,7 +1932,7 @@ create_temp_files() {
 configure_emergency_numbers() {
 	local emergency
 
-	eval "$(config_foreach get_prefixinfo prefixinfo "EMERGENCY")"
+	config_foreach get_prefixinfo prefixinfo "EMERGENCY"
 
 	ast_conf_replace_esc "|EMERGENCY_NUMBERS|" "$emergency" $WORK_DIR/chan_telephony.conf
 }