-
Andy Green authored
The function has a logical problem when the size of the requested allocation is 0, it will return NULL which is overloaded as failure. Actually the whole function is evil as an api, this patch moves it out of the public API space and fixes it to return 0 for success or 1 for fail. Private code does not need to to return wsi->user_space and public code should only get that from the callback as discussed on trac recently. Thanks to Edwin for debugging the problem. Reported-by:
Edwin van den Oetelaar <oetelaar.automatisering@gmail.com> Signed-off-by:
Andy Green <andy.green@linaro.org>
Andy Green authoredThe function has a logical problem when the size of the requested allocation is 0, it will return NULL which is overloaded as failure. Actually the whole function is evil as an api, this patch moves it out of the public API space and fixes it to return 0 for success or 1 for fail. Private code does not need to to return wsi->user_space and public code should only get that from the callback as discussed on trac recently. Thanks to Edwin for debugging the problem. Reported-by:
Edwin van den Oetelaar <oetelaar.automatisering@gmail.com> Signed-off-by:
Andy Green <andy.green@linaro.org>