Skip to content
Snippets Groups Projects
  • Samuel Holland's avatar
    344df3ca
    include: axp_pmic: Include headers for all variants · 344df3ca
    Samuel Holland authored
    
    A single DM-based driver should be able to support some feature for
    several PMIC variants where the interface is the same. For example,
    all PMIC variants use the same register bit to trigger poweroff.
    
    However, currently only definitions for a single PMIC are available at
    a time. This requires drivers to use #ifdefs and different indentifiers
    for each variant they support.
    
    Let's simplify this by making register definitions for all variants
    available from the header. Then no preprocessor conditions are needed;
    the driver can use the register definition from any variant that
    supports the relevant feature.
    
    An exception is the GPIO-related definitions, which do not use unique
    identifiers. So for now, keep them like before. They will be cleaned up
    along with the GPIO driver.
    
    Signed-off-by: default avatarSamuel Holland <samuel@sholland.org>
    Reviewed-by: default avatarAndre Przywara <andre.przywara@arm.com>
    Signed-off-by: default avatarAndre Przywara <andre.przywara@arm.com>
    344df3ca
    History
    include: axp_pmic: Include headers for all variants
    Samuel Holland authored
    
    A single DM-based driver should be able to support some feature for
    several PMIC variants where the interface is the same. For example,
    all PMIC variants use the same register bit to trigger poweroff.
    
    However, currently only definitions for a single PMIC are available at
    a time. This requires drivers to use #ifdefs and different indentifiers
    for each variant they support.
    
    Let's simplify this by making register definitions for all variants
    available from the header. Then no preprocessor conditions are needed;
    the driver can use the register definition from any variant that
    supports the relevant feature.
    
    An exception is the GPIO-related definitions, which do not use unique
    identifiers. So for now, keep them like before. They will be cleaned up
    along with the GPIO driver.
    
    Signed-off-by: default avatarSamuel Holland <samuel@sholland.org>
    Reviewed-by: default avatarAndre Przywara <andre.przywara@arm.com>
    Signed-off-by: default avatarAndre Przywara <andre.przywara@arm.com>
axp_pmic.h 1.20 KiB