-
- Downloads
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by:
Masahiro Yamada <masahiroy@kernel.org>
Showing
- arch/arm/cpu/arm1136/mx35/generic.c 2 additions, 2 deletionsarch/arm/cpu/arm1136/mx35/generic.c
- arch/arm/cpu/arm926ejs/mx25/generic.c 2 additions, 2 deletionsarch/arm/cpu/arm926ejs/mx25/generic.c
- arch/arm/cpu/arm926ejs/mx27/generic.c 2 additions, 2 deletionsarch/arm/cpu/arm926ejs/mx27/generic.c
- arch/arm/cpu/arm926ejs/mxs/mxs.c 1 addition, 1 deletionarch/arm/cpu/arm926ejs/mxs/mxs.c
- arch/arm/cpu/arm926ejs/mxs/spl_boot.c 1 addition, 1 deletionarch/arm/cpu/arm926ejs/mxs/spl_boot.c
- arch/arm/cpu/armv7/ls102xa/cpu.c 2 additions, 2 deletionsarch/arm/cpu/armv7/ls102xa/cpu.c
- arch/arm/cpu/armv7/ls102xa/fdt.c 1 addition, 1 deletionarch/arm/cpu/armv7/ls102xa/fdt.c
- arch/arm/cpu/armv7/vf610/generic.c 2 additions, 2 deletionsarch/arm/cpu/armv7/vf610/generic.c
- arch/arm/cpu/armv8/fsl-layerscape/cpu.c 2 additions, 2 deletionsarch/arm/cpu/armv8/fsl-layerscape/cpu.c
- arch/arm/cpu/armv8/fsl-layerscape/fdt.c 1 addition, 1 deletionarch/arm/cpu/armv8/fsl-layerscape/fdt.c
- arch/arm/cpu/armv8/s32v234/generic.c 1 addition, 1 deletionarch/arm/cpu/armv8/s32v234/generic.c
- arch/arm/include/asm/arch-mx27/mxcmmc.h 1 addition, 1 deletionarch/arm/include/asm/arch-mx27/mxcmmc.h
- arch/arm/include/asm/arch-mx31/sys_proto.h 1 addition, 1 deletionarch/arm/include/asm/arch-mx31/sys_proto.h
- arch/arm/include/asm/arch-mx6/litesom.h 1 addition, 1 deletionarch/arm/include/asm/arch-mx6/litesom.h
- arch/arm/include/asm/arch-mxs/sys_proto.h 2 additions, 1 deletionarch/arm/include/asm/arch-mxs/sys_proto.h
- arch/arm/lib/bdinfo.c 1 addition, 1 deletionarch/arm/lib/bdinfo.c
- arch/arm/lib/bootm-fdt.c 1 addition, 1 deletionarch/arm/lib/bootm-fdt.c
- arch/arm/lib/bootm.c 6 additions, 5 deletionsarch/arm/lib/bootm.c
- arch/arm/lib/cache-cp15.c 1 addition, 1 deletionarch/arm/lib/cache-cp15.c
- arch/arm/mach-imx/cpu.c 2 additions, 2 deletionsarch/arm/mach-imx/cpu.c
Loading
Please register or sign in to comment