Skip to content
Snippets Groups Projects

RMON stats and Eth stats implementation for HSGMII LAN driver

Merged Arun Muthusamy requested to merge Bug_12103 into devel

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Arun Muthusamy requested review from @marsik

    requested review from @marsik

  • assigned to @rthakur

  • In general looks fine, my only concerns are about hsgmii index and copying of fe_type.h header.

    Regarding hsgmii index, from Airoha code it could be different (theoretically the driver could handle up to 3 interfaces eth1/eth2/eth3 with different serdes sel). But for currently supported boards in iowrt we have it only as specified here (eth1, index 2 - usb serdes sel), so it is ok right now.

    Regarding copying of the header, my worries are that we will forget to update it in case of changes in next Airoha SDKs. On the other hand, I doubt that Airoha will change statistics structures, so that is acceptable right now as well.

  • Marina Maslova approved this merge request

    approved this merge request

  • merged

Please register or sign in to reply
Loading