RMON stats and Eth stats implementation for HSGMII LAN driver
Merge request reports
Activity
requested review from @marsik
assigned to @rthakur
In general looks fine, my only concerns are about hsgmii index and copying of fe_type.h header.
Regarding hsgmii index, from Airoha code it could be different (theoretically the driver could handle up to 3 interfaces eth1/eth2/eth3 with different serdes sel). But for currently supported boards in iowrt we have it only as specified here (eth1, index 2 - usb serdes sel), so it is ok right now.
Regarding copying of the header, my worries are that we will forget to update it in case of changes in next Airoha SDKs. On the other hand, I doubt that Airoha will change statistics structures, so that is acceptable right now as well.
Please register or sign in to reply