Tests do not give warnings anymore

README.md

@@ -33,5 +33,4 @@ TODO
 ===
 
 - Reimplement the `reload` method provided by existing scripts
-- Tests
 - Integration in the OS build
\ No newline at end of file

test/cmocka/functional_test_qos.c

@@ -49,13 +49,6 @@ static int group_teardown(void **state)
 	return 0;
 }
 
-static int setup(void **state)
-{
-	struct test_ctx *ctx = (struct test_ctx *) *state;
-
-	return 0;
-}
-
 int main(void)
 {
 	const struct CMUnitTest tests[] = {	};

test/cmocka/unit_test_qos.c

@@ -37,7 +37,7 @@ int ubus_send_reply(struct ubus_context *ctx, struct ubus_request_data *req,
 char *multi_tok(char *input, char *delimiter)
 {
     static char *string;
-	char *end, temp;
+	char *end, *temp;
 
     if (input)
         string = input;
@@ -70,11 +70,10 @@ struct json_object *poll_test_log(FILE *fp, const char *prefix)
 	char msg[256] = {0};
 	struct json_object *obj = NULL;
 
-	//if (!fp) {
     fp = fopen("/tmp/test.log", "r");
-    if (!fp)
+    if (!fp) {
         return NULL;
-	//}
+    }
 
 	while (fgets(line, 256, fp))  {
 		char *ptr, *s;
@@ -129,15 +128,6 @@ static int group_teardown(void **state)
 	return 0;
 }
 
-static int setup(void **state)
-{
-	struct test_ctx *ctx = (struct test_ctx *) *state;
-
-	blob_buf_init(&ctx->bb, 0);
-
-	return 0;
-}
-
 int main(void)
 {
 	const struct CMUnitTest tests[] = {