Skip to content
Snippets Groups Projects
  • Christian Marangi's avatar
    53a08e37
    build: make find_md5 reproducible with AUTOREMOVE · 53a08e37
    Christian Marangi authored
    
    While experimenting with the AUTOREMOVE option in search of a way to use
    prebuilt host tools in different buildroot, it was discovered that the
    md5 generated by find_md5 in depends.mk is not reproducible.
    
    Currently the hash is generated by the path of the file in addition to
    the file mod time. Out of confusion, probably, there was an idea that
    such command was used on the package build_dir. Reality is that this
    command is run on the package files. (Makefile, patches, src)
    
    This is problematic because the package Makefile (for example) change at
    each git clone and base the hash on the Makefile mtime doesn't really
    reflect if the Makefile actually changes across a buildroot or not.
    
    A better approach is to generate an hash of each file and then generate
    an hash on the sort hash list. This way we remove the problem of git
    clone setting a wrong mtime while keeping the integrity of checking if a
    file changed for the package as any change will result in a different
    hash.
    
    Introduce a new kind of find_md5 function, find_md5_reproducible that
    apply this new logic and limit it only with AUTOREMOVE option set to
    prevent any kind of slowdown due to additional hash generation.
    
    Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
    53a08e37
    History
    build: make find_md5 reproducible with AUTOREMOVE
    Christian Marangi authored
    
    While experimenting with the AUTOREMOVE option in search of a way to use
    prebuilt host tools in different buildroot, it was discovered that the
    md5 generated by find_md5 in depends.mk is not reproducible.
    
    Currently the hash is generated by the path of the file in addition to
    the file mod time. Out of confusion, probably, there was an idea that
    such command was used on the package build_dir. Reality is that this
    command is run on the package files. (Makefile, patches, src)
    
    This is problematic because the package Makefile (for example) change at
    each git clone and base the hash on the Makefile mtime doesn't really
    reflect if the Makefile actually changes across a buildroot or not.
    
    A better approach is to generate an hash of each file and then generate
    an hash on the sort hash list. This way we remove the problem of git
    clone setting a wrong mtime while keeping the integrity of checking if a
    file changed for the package as any change will result in a different
    hash.
    
    Introduce a new kind of find_md5 function, find_md5_reproducible that
    apply this new logic and limit it only with AUTOREMOVE option set to
    prevent any kind of slowdown due to additional hash generation.
    
    Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>