Skip to content
Snippets Groups Projects
Commit aee3594f authored by Paul Spooren's avatar Paul Spooren
Browse files

verbose.mk: print ERROR messages in non-verbose


Using `make -j9` only prints a subset of messages to follow the build
process progressing. However this silently skips over errors which might
be of interested. Using `make V=s` easily floods the terminal making it
hard to find error messages between the lines.

A compromise is the usage of `$(call ERROR_MESSAGE,...)` which prints a
message in red. This function is silenced in the non-verbose mode, even
if only used at a single place in `package/Makefile` where it notifies
about a OPKG corner case.

This commit moves the `ERROR_MESSAGE` definition outside of the
`OPENWRT_VERBOSE` condition and print error messages in every mode.

With this in place further error messages are possible.

Signed-off-by: default avatarPaul Spooren <mail@aparcar.org>
parent d4c20ff9
Branches
Tags
1 merge request!79Merge OpenWrt 22.03.0-rc4
...@@ -29,15 +29,15 @@ ifeq ($(IS_TTY),1) ...@@ -29,15 +29,15 @@ ifeq ($(IS_TTY),1)
endif endif
endif endif
define ERROR_MESSAGE
printf "$(_R)%s$(_N)\n" "$(1)" >&8
endef
ifeq ($(findstring s,$(OPENWRT_VERBOSE)),) ifeq ($(findstring s,$(OPENWRT_VERBOSE)),)
define MESSAGE define MESSAGE
printf "$(_Y)%s$(_N)\n" "$(1)" >&8 printf "$(_Y)%s$(_N)\n" "$(1)" >&8
endef endef
define ERROR_MESSAGE
printf "$(_R)%s$(_N)\n" "$(1)" >&8
endef
ifeq ($(QUIET),1) ifeq ($(QUIET),1)
ifneq ($(CURDIR),$(TOPDIR)) ifneq ($(CURDIR),$(TOPDIR))
_DIR:=$(patsubst $(TOPDIR)/%,%,${CURDIR}) _DIR:=$(patsubst $(TOPDIR)/%,%,${CURDIR})
...@@ -60,5 +60,4 @@ else ...@@ -60,5 +60,4 @@ else
define MESSAGE define MESSAGE
printf "%s\n" "$(1)" printf "%s\n" "$(1)"
endef endef
ERROR_MESSAGE=$(MESSAGE)
endif endif
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment