return -EINVAL when controller_command_parse() fails

src/cntlr_commands_impl.c

@@ -68,7 +68,7 @@ int COMMAND(help)(void *priv, void *args, void *out)
 	ret = controller_command_parse("help", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	if (tb[HELP_ATTR_COMMAND_NAME])
@@ -140,7 +140,7 @@ int COMMAND(send_topology_query)(void *priv, void *args, void *out)
 	ret = controller_command_parse("send_topology_query", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	strncpy(agent, blobmsg_data(tb[TOPOLOGY_QUERY_ATTR_AGENT]), sizeof(agent) - 1);
@@ -185,7 +185,7 @@ int COMMAND(scan)(void *priv, void *args, void *out)
 	ret = controller_command_parse("scan", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	strncpy(agent_macstr, blobmsg_data(tb[SCAN_ATTR_AGENT]), sizeof(agent_macstr) - 1);
@@ -361,7 +361,7 @@ int COMMAND(scanresults)(void *priv, void *args, void *out)
 	ret = controller_command_parse("scanresults", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	strncpy(agentstr, blobmsg_data(tb[SCANRESULTS_ATTR_AGENT]), sizeof(agentstr) - 1);
@@ -560,7 +560,7 @@ int COMMAND(cac_start)(void *priv, void *args, void *out)
 	ret = controller_command_parse("cac_start", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	strncpy(agent_macstr, blobmsg_data(tb[CAC_START_ATTR_AGENT]), sizeof(agent_macstr) - 1);
@@ -747,7 +747,7 @@ int COMMAND(send_combined_metrics)(void *priv, void *args, void *out)
 	ret = controller_command_parse("send_combined_metrics", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	strncpy(agent, blobmsg_data(tb[COMBINED_METRICS_ATTR_AGENT]), sizeof(agent) - 1);
@@ -796,7 +796,7 @@ int COMMAND(send_hld)(void *priv, void *args, void *out)
 	ret = controller_command_parse("send_hld", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	strncpy(agent, blobmsg_data(tb[HLD_ATTR_AGENT]), sizeof(agent) - 1);
@@ -870,7 +870,7 @@ int COMMAND(send_channel_sel)(void *priv, void *args, void *out)
 	ret = controller_command_parse("send_channel_sel", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	strncpy(agent, blobmsg_data(tb[CHANNEL_SEL_ATTR_AGENT]), sizeof(agent) - 1);
@@ -1412,7 +1412,7 @@ int COMMAND(query_sta_caps)(void *priv, void *args, void *out)
 	ret = controller_command_parse("query_sta_caps", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	memset(mac, 0, sizeof(mac));
@@ -1459,7 +1459,7 @@ int COMMAND(query_bsta_caps)(void *priv, void *args, void *out)
 	ret = controller_command_parse("query_bsta_caps", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	memset(agent, 0, sizeof(agent));
@@ -1502,7 +1502,7 @@ int COMMAND(query_ap_metrics)(void *priv, void *args, void *out)
 	ret = controller_command_parse("query_ap_metrics", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	strncpy(agent, blobmsg_data(tb[AP_METRICS_ATTR_AGENT]), sizeof(agent) - 1);
@@ -1612,7 +1612,7 @@ int COMMAND(query_sta_metrics)(void *priv, void *args, void *out)
 	ret = controller_command_parse("query_sta_metrics", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	memset(mac_str, 0, sizeof(mac_str));
@@ -1681,7 +1681,7 @@ int COMMAND(dump_steer_summary)(void *priv, void *args, void *out)
 	ret = controller_command_parse("dump_steer_summary", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	if (tb[STEER_SUMMARY_ATTR_STA]) {
@@ -1757,7 +1757,7 @@ int COMMAND(dump_steer_history)(void *priv, void *args, void *out)
 	ret = controller_command_parse("dump_steer_history", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	if (tb[STEER_HISTORY_ATTR_STA]) {
@@ -1827,7 +1827,7 @@ int COMMAND(dump_unassoc_sta_metrics)(void *priv, void *args, void *out)
 	ret = controller_command_parse("dump_unassoc_sta_metrics", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	if (tb[UNASSOC_STA_METRICS_DUMP_ATTR_STA]) {
@@ -1890,7 +1890,7 @@ int COMMAND(query_unassoc_sta_metrics)(void *priv, void *args, void *out)
 	ret = controller_command_parse("query_unassoc_sta_metrics", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	strncpy(mac_str, blobmsg_data(tb[UNASSOC_STA_METRICS_ATTR_AGENT]), sizeof(mac_str) - 1);
@@ -2040,7 +2040,7 @@ int COMMAND(query_channel_pref)(void *priv, void *args, void *out)
 	ret = controller_command_parse("query_channel_pref", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	if (tb[CHANNEL_PREF_ATTR_AGENT]) {
@@ -2118,7 +2118,7 @@ int COMMAND(dump_beacon_metrics)(void *priv, void *args, void *out)
 	ret = controller_command_parse("dump_beacon_metrics", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	if (tb[BCN_METRICS_DUMP_ATTR_STA]) {
@@ -2174,7 +2174,7 @@ int COMMAND(query_beacon_metrics)(void *priv, void *args, void *out)
 	ret = controller_command_parse("query_beacon_metrics", args, tb);
 	if (ret) {
 		err("%s: Error (ret = %d)\n", __func__, ret);
-		return ret;
+		return -EINVAL;
 	}
 
 	strncpy(agent, blobmsg_data(tb[BCN_METRICS_ATTR_AGENT]), sizeof(agent) - 1);