warn if STA is added/removed to/from node incorrectly

src/cntlr.c

@@ -484,6 +484,13 @@ void cntlr_bcn_metrics_timer_cb(atimer_t *t)
 
 void node_add_sta(struct node *n, struct sta *s)
 {
+	if (WARN_ON(node_find_sta(n, s->macaddr))) {
+		cntlr_dbg(LOG_STA,
+			  "%s: Warn! STA " MACFMT " already in node " MACFMT"\n",
+			  __func__, MAC2STR(s->macaddr), MAC2STR(n->almacaddr));
+		return;
+	}
+
 	memcpy(s->agent_almacaddr, n->almacaddr, 6);
 	list_add(&s->list, &n->stalist);
 	n->sta_count++;
@@ -491,6 +498,13 @@ void node_add_sta(struct node *n, struct sta *s)
 
 void node_del_sta(struct node *n, struct sta *s)
 {
+	if (WARN_ON(!node_find_sta(n, s->macaddr))) {
+		cntlr_dbg(LOG_STA,
+			  "%s: Warn! STA " MACFMT " not in node " MACFMT"\n",
+			  __func__, MAC2STR(s->macaddr), MAC2STR(n->almacaddr));
+		return;
+	}
+
 	list_del(&s->list);
 	n->sta_count--;
 }