Fix pipeline

src/ipv6rd.c

@@ -91,7 +91,7 @@ static int browseIPv6rdInterfaceSettingInst(struct dmctx *dmctx, DMNODE *parent_
 static int get_IPv6rd_Enable(char *refparam, struct dmctx *ctx, void *data, char *instance, char **value)
 {
 	// no way to disable ipv6rd for now, always enabled
-	*value = "1";
+	*value = dmstrdup("1");
 	return 0;
 }
 
@@ -118,8 +118,6 @@ static int get_IPv6rd_InterfaceSettingNumberOfEntries(char *refparam, struct dmc
 
 static int get_IPv6rdInterfaceSetting_Enable(char *refparam, struct dmctx *ctx, void *data, char *instance, char **value)
 {
-	*value = "0";
-
 	if (((struct dm_data *)data)->config_section == NULL)
 		return 0;
 
@@ -127,7 +125,7 @@ static int get_IPv6rdInterfaceSetting_Enable(char *refparam, struct dmctx *ctx,
 	dmuci_get_value_by_section_string(((struct dm_data *)data)->config_section, "disabled", &disabled);
 
 	if (DM_STRCMP(disabled, "1") != 0)
-		*value = "1";
+		*value = dmstrdup("1");
 
 	return 0;
 }
@@ -171,10 +169,8 @@ static int set_IPv6rdInterfaceSetting_Alias(char *refparam, struct dmctx *ctx, v
 
 static int get_IPv6rdInterfaceSetting_BorderRelayIPv4Addresses(char *refparam, struct dmctx *ctx, void *data, char *instance, char **value)
 {
-	if (((struct dm_data *)data)->config_section == NULL) {
-		*value = "";
+	if (((struct dm_data *)data)->config_section == NULL)
 		return 0;
-	}
 
 	dmuci_get_value_by_section_string(((struct dm_data *)data)->config_section, "peeraddr", value);
 	return 0;
@@ -198,12 +194,11 @@ static int set_IPv6rdInterfaceSetting_BorderRelayIPv4Addresses(char *refparam, s
 
 static int get_IPv6rdInterfaceSetting_AllTrafficToBorderRelay(char *refparam, struct dmctx *ctx, void *data, char *instance, char **value)
 {
-	if (((struct dm_data *)data)->config_section == NULL) {
-		*value = "";
+	if (((struct dm_data *)data)->config_section == NULL)
 		return 0;
-	}
+
 	// this is always true in openwrt
-	*value = "1";
+	*value = dmstrdup("1");
 	return 0;
 }
 
@@ -224,8 +219,6 @@ static int set_IPv6rdInterfaceSetting_AllTrafficToBorderRelay(char *refparam, st
 
 static int get_IPv6rdInterfaceSetting_SPIPv6Prefix(char *refparam, struct dmctx *ctx, void *data, char *instance, char **value)
 {
-	*value = "";
-
 	if (((struct dm_data *)data)->config_section == NULL)
 		return 0;
 
@@ -268,10 +261,8 @@ static int set_IPv6rdInterfaceSetting_SPIPv6Prefix(char *refparam, struct dmctx
 
 static int get_IPv6rdInterfaceSetting_IPv4MaskLength(char *refparam, struct dmctx *ctx, void *data, char *instance, char **value)
 {
-	if (((struct dm_data *)data)->config_section == NULL) {
-		*value = "";
+	if (((struct dm_data *)data)->config_section == NULL)
 		return 0;
-	}
 
 	dmuci_get_value_by_section_string(((struct dm_data *)data)->config_section, "ip4prefixlen", value);
 	return 0;
@@ -294,10 +285,8 @@ static int set_IPv6rdInterfaceSetting_IPv4MaskLength(char *refparam, struct dmct
 
 static int get_IPv6rdInterfaceSetting_AddressSource(char *refparam, struct dmctx *ctx, void *data, char *instance, char **value)
 {
-	if (((struct dm_data *)data)->config_section == NULL) {
-		*value = "";
+	if (((struct dm_data *)data)->config_section == NULL)
 		return 0;
-	}
 
 	dmuci_get_value_by_section_string(((struct dm_data *)data)->dmmap_section, "ipv4path", value);
 
@@ -343,7 +332,7 @@ static int get_IPv6rdInterfaceSetting_TunnelInterface(char *refparam, struct dmc
 {
 	// Tunnel, Tunneled interfaces are not yet supported
 	// when their support is added, we can update this function
-	*value = "";
+	// TODO
 	return 0;
 }
 
@@ -351,7 +340,7 @@ static int get_IPv6rdInterfaceSetting_TunneledInterface(char *refparam, struct d
 {
 	// Tunnel, Tunneled interfaces are not yet supported
 	// when their support is added, we can update this function
-	*value = "";
+	// TODO
 	return 0;
 }