Skip to content
Snippets Groups Projects
  • Richard Mudgett's avatar
    03beadb6
    internal_timing: Remove the option and always make it enabled if a timing module is loaded. · 03beadb6
    Richard Mudgett authored
    The masquerade supertest frequently fails because either the local channel
    chain doesn't completely optimize out or the DTMF handshake doesn't
    completely get accross.  Local channel optimization requires frames
    flowing to trigger when optimization can happen.  When optimization
    happens the media frame that triggered the optimization is dropped.
    Sending DTMF requires frames to flow in the other direction for timing
    purposes while sending nothing.  If internal timing is not enabled when
    MOH is playing, Asterisk switches to received timing when an audio frame
    is received.  With optimization dropping media frames and MOH not sending
    frames unless it receives frames, occasionaly there are no more frames
    being passed and the test fails.
    
    * The asterisk command line -I option and the asterisk.conf
    internal_timing option are removed.  Asterisk now always uses internal
    timing when needed if any timing module is loaded.  The issue
    ASTERISK-14861 did this quite awhile ago in v1.4 but effectively is broken
    if other internal timing modules besides DAHDI are used.  The
    ast_read_generator_actions() now only does received timing if it has no
    choice for frame generators like MOH, silence, and playback streaming.
    
    * Cleaned up some code dealing with frame generators in
    ast_deactivate_generator(), generator_write_format_change(),
    ast_activate_generator(), and ast_channel_stop_silence_generator().
    
    * Removed ast_internal_timing_enabled(), AST_OPT_FLAG_INTERNAL_TIMING, and
    ast_opt_internal_timing.
    
    ASTERISK-22846 #close
    Reported by: Matt Jordan
    
    Review: https://reviewboard.asterisk.org/r/3414/
    ........
    
    Merged revisions 411715 from http://svn.asterisk.org/svn/asterisk/branches/1.8
    ........
    
    Merged revisions 411716 from http://svn.asterisk.org/svn/asterisk/branches/11
    ........
    
    Merged revisions 411717 from http://svn.asterisk.org/svn/asterisk/branches/12
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@411724 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    03beadb6
    History
    internal_timing: Remove the option and always make it enabled if a timing module is loaded.
    Richard Mudgett authored
    The masquerade supertest frequently fails because either the local channel
    chain doesn't completely optimize out or the DTMF handshake doesn't
    completely get accross.  Local channel optimization requires frames
    flowing to trigger when optimization can happen.  When optimization
    happens the media frame that triggered the optimization is dropped.
    Sending DTMF requires frames to flow in the other direction for timing
    purposes while sending nothing.  If internal timing is not enabled when
    MOH is playing, Asterisk switches to received timing when an audio frame
    is received.  With optimization dropping media frames and MOH not sending
    frames unless it receives frames, occasionaly there are no more frames
    being passed and the test fails.
    
    * The asterisk command line -I option and the asterisk.conf
    internal_timing option are removed.  Asterisk now always uses internal
    timing when needed if any timing module is loaded.  The issue
    ASTERISK-14861 did this quite awhile ago in v1.4 but effectively is broken
    if other internal timing modules besides DAHDI are used.  The
    ast_read_generator_actions() now only does received timing if it has no
    choice for frame generators like MOH, silence, and playback streaming.
    
    * Cleaned up some code dealing with frame generators in
    ast_deactivate_generator(), generator_write_format_change(),
    ast_activate_generator(), and ast_channel_stop_silence_generator().
    
    * Removed ast_internal_timing_enabled(), AST_OPT_FLAG_INTERNAL_TIMING, and
    ast_opt_internal_timing.
    
    ASTERISK-22846 #close
    Reported by: Matt Jordan
    
    Review: https://reviewboard.asterisk.org/r/3414/
    ........
    
    Merged revisions 411715 from http://svn.asterisk.org/svn/asterisk/branches/1.8
    ........
    
    Merged revisions 411716 from http://svn.asterisk.org/svn/asterisk/branches/11
    ........
    
    Merged revisions 411717 from http://svn.asterisk.org/svn/asterisk/branches/12
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@411724 65c4cc65-6c06-0410-ace0-fbb531ad65f3