Skip to content
Snippets Groups Projects
  • Terry Wilson's avatar
    04da92c3
    Replace direct access to channel name with accessor functions · 04da92c3
    Terry Wilson authored
    There are many benefits to making the ast_channel an opaque handle, from
    increasing maintainability to presenting ways to kill masquerades. This patch
    kicks things off by taking things a field at a time, renaming the field to
    '__do_not_use_${fieldname}' and then writing setters/getters and converting the
    existing code to using them. When all fields are done, we can move ast_channel
    to a C file from channel.h and lop off the '__do_not_use_'.
    
    This patch sets up main/channel_interal_api.c to be the only file that actually
    accesses the ast_channel's fields directly. The intent would be for any API
    functions in channel.c to use the accessor functions. No more monkeying around
    with channel internals. We should use our own APIs.
    
    The interesting changes in this patch are the addition of
    channel_internal_api.c, the moving of the AST_DATA stuff from channel.c to
    channel_internal_api.c (note: the AST_DATA stuff will have to be reworked to
    use accessor functions when ast_channel is really opaque), and some re-working
    of the way channel iterators/callbacks are handled so as to avoid creating fake
    ast_channels on the stack to pass in matching data by directly accessing fields
    (since "name" is a stringfield and the fake channel doesn't init the
    stringfields, you can't use the ast_channel_name_set() function). I went with
    ast_channel_name(chan) for a getter, and ast_channel_name_set(chan, name) for a
    setter.
    
    The majority of the grunt-work for this change was done by writing a semantic
    patch using Coccinelle ( http://coccinelle.lip6.fr/ ).
    
    Review: https://reviewboard.asterisk.org/r/1655/
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@350223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    04da92c3
    History
    Replace direct access to channel name with accessor functions
    Terry Wilson authored
    There are many benefits to making the ast_channel an opaque handle, from
    increasing maintainability to presenting ways to kill masquerades. This patch
    kicks things off by taking things a field at a time, renaming the field to
    '__do_not_use_${fieldname}' and then writing setters/getters and converting the
    existing code to using them. When all fields are done, we can move ast_channel
    to a C file from channel.h and lop off the '__do_not_use_'.
    
    This patch sets up main/channel_interal_api.c to be the only file that actually
    accesses the ast_channel's fields directly. The intent would be for any API
    functions in channel.c to use the accessor functions. No more monkeying around
    with channel internals. We should use our own APIs.
    
    The interesting changes in this patch are the addition of
    channel_internal_api.c, the moving of the AST_DATA stuff from channel.c to
    channel_internal_api.c (note: the AST_DATA stuff will have to be reworked to
    use accessor functions when ast_channel is really opaque), and some re-working
    of the way channel iterators/callbacks are handled so as to avoid creating fake
    ast_channels on the stack to pass in matching data by directly accessing fields
    (since "name" is a stringfield and the fake channel doesn't init the
    stringfields, you can't use the ast_channel_name_set() function). I went with
    ast_channel_name(chan) for a getter, and ast_channel_name_set(chan, name) for a
    setter.
    
    The majority of the grunt-work for this change was done by writing a semantic
    patch using Coccinelle ( http://coccinelle.lip6.fr/ ).
    
    Review: https://reviewboard.asterisk.org/r/1655/
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@350223 65c4cc65-6c06-0410-ace0-fbb531ad65f3