Skip to content
Snippets Groups Projects
  • Terry Wilson's avatar
    68d1ded8
    Only change the RTP ssrc when we see that it has changed · 68d1ded8
    Terry Wilson authored
    This change basically reverts the change reviewed in
    https://reviewboard.asterisk.org/r/374/ and instead limits the
    updating of the RTP synchronization source to only those times when we
    detect that the other side of the conversation has changed the ssrc.
    
    The problem is that SRCUPDATE control frames are sent many times where
    we don't want a new ssrc, including whenever Asterisk has to send DTMF
    in a normal bridge. This is also not the first time that this mistake
    has been made. The initial implementation of the ast_rtp_new_source
    function also changed the ssrc--and then it was removed because of
    this same issue. Then, we put it back in again to fix a different
    issue. This patch attempts to only change the ssrc when we see that
    the other side of the conversation has changed the ssrc.
    
    It also renames some functions to make their purpose more clear.
    
    Review: https://reviewboard.asterisk.org/r/540/
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252089 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    68d1ded8
    History
    Only change the RTP ssrc when we see that it has changed
    Terry Wilson authored
    This change basically reverts the change reviewed in
    https://reviewboard.asterisk.org/r/374/ and instead limits the
    updating of the RTP synchronization source to only those times when we
    detect that the other side of the conversation has changed the ssrc.
    
    The problem is that SRCUPDATE control frames are sent many times where
    we don't want a new ssrc, including whenever Asterisk has to send DTMF
    in a normal bridge. This is also not the first time that this mistake
    has been made. The initial implementation of the ast_rtp_new_source
    function also changed the ssrc--and then it was removed because of
    this same issue. Then, we put it back in again to fix a different
    issue. This patch attempts to only change the ssrc when we see that
    the other side of the conversation has changed the ssrc.
    
    It also renames some functions to make their purpose more clear.
    
    Review: https://reviewboard.asterisk.org/r/540/
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@252089 65c4cc65-6c06-0410-ace0-fbb531ad65f3