Skip to content
Snippets Groups Projects
  • Richard Mudgett's avatar
    1ba13718
    assigned-uniqueids: Miscellaneous cleanup and fixes. · 1ba13718
    Richard Mudgett authored
    * Fix memory leak in ast_unreal_new_channels().  Made it generate the ;2
    uniqueid on a stack variable instead of mallocing it.
    
    * Made send error response to ARI and AMI requests instead of just logging
    excessive uniqueid length and allowing truncation.  action_originate() and
    ari_channels_handle_originate_with_id().
    
    * Fixed minor truncating uniqueid hole when generating the ;2 uniqueid
    string length.  Created public and internal lengths of uniqueid.  The
    internal length can handle a max public uniqueid plus an appended ;2.
    
    * free() and ast_free() are NULL tolerant so they don't need a NULL test
    before calling.
    
    * Made use better struct initialization format instead of the position
    dependent initialization format.  Also anything not explicitly initialized
    in the struct is initialized to zero by the compiler.
    
    * Made ast_channel_internal_set_fake_ids() use the safer
    ast_copy_string() instead of strncpy().
    
    Review: https://reviewboard.asterisk.org/r/3371/
    ........
    
    Merged revisions 410949 from http://svn.asterisk.org/svn/asterisk/branches/12
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@410950 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    1ba13718
    History
    assigned-uniqueids: Miscellaneous cleanup and fixes.
    Richard Mudgett authored
    * Fix memory leak in ast_unreal_new_channels().  Made it generate the ;2
    uniqueid on a stack variable instead of mallocing it.
    
    * Made send error response to ARI and AMI requests instead of just logging
    excessive uniqueid length and allowing truncation.  action_originate() and
    ari_channels_handle_originate_with_id().
    
    * Fixed minor truncating uniqueid hole when generating the ;2 uniqueid
    string length.  Created public and internal lengths of uniqueid.  The
    internal length can handle a max public uniqueid plus an appended ;2.
    
    * free() and ast_free() are NULL tolerant so they don't need a NULL test
    before calling.
    
    * Made use better struct initialization format instead of the position
    dependent initialization format.  Also anything not explicitly initialized
    in the struct is initialized to zero by the compiler.
    
    * Made ast_channel_internal_set_fake_ids() use the safer
    ast_copy_string() instead of strncpy().
    
    Review: https://reviewboard.asterisk.org/r/3371/
    ........
    
    Merged revisions 410949 from http://svn.asterisk.org/svn/asterisk/branches/12
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@410950 65c4cc65-6c06-0410-ace0-fbb531ad65f3