Skip to content
Snippets Groups Projects
  • Naveen Albert's avatar
    80e6205b
    res_adsi: Fix major regression caused by media format rearchitecture. · 80e6205b
    Naveen Albert authored
    The commit that rearchitected media formats,
    a2c912e9 (ASTERISK_23114)
    introduced a regression by improperly translating code in res_adsi.c.
    In particular, the pointer to the frame buffer was initialized
    at the top of adsi_careful_send, rather than dynamically updating it
    for each frame, as is required.
    
    This resulted in the first frame being repeatedly sent,
    rather than advancing through the frames.
    This corrupted the transmission of the CAS to the CPE,
    which meant that CPE would never respond with the DTMF acknowledgment,
    effectively completely breaking ADSI functionality.
    
    This issue is now fixed, and ADSI now works properly again.
    
    ASTERISK-29793 #close
    
    Change-Id: Icdeddf733eda2981c98712d1ac9cddc0db507dbe
    80e6205b
    History
    res_adsi: Fix major regression caused by media format rearchitecture.
    Naveen Albert authored
    The commit that rearchitected media formats,
    a2c912e9 (ASTERISK_23114)
    introduced a regression by improperly translating code in res_adsi.c.
    In particular, the pointer to the frame buffer was initialized
    at the top of adsi_careful_send, rather than dynamically updating it
    for each frame, as is required.
    
    This resulted in the first frame being repeatedly sent,
    rather than advancing through the frames.
    This corrupted the transmission of the CAS to the CPE,
    which meant that CPE would never respond with the DTMF acknowledgment,
    effectively completely breaking ADSI functionality.
    
    This issue is now fixed, and ADSI now works properly again.
    
    ASTERISK-29793 #close
    
    Change-Id: Icdeddf733eda2981c98712d1ac9cddc0db507dbe