res/res_pjsip_outbound_authenticator_digest.c · 2a34bb1e11d9c812dd32d0fb16bed5d0ffc78cf0 · Voice / asterisk

3 years ago

res_pjsip_outbound_authenticator_digest: Prevent ABRT on cleanup · 2a34bb1e

George Joseph authored 3 years ago

In dev mode, if you call pjsip_auth_clt_deinit() with an auth_sess
that hasn't been initialized, it'll assert and abort.  If
digest_create_request_with_auth() fails to find the proper
auth object however, it jumps to its cleanup which does exactly
that.  So now we no longer attempt to call pjsip_auth_clt_deinit()
if we never actually initialized it.

ASTERISK-29888

Change-Id: Ib6171c25c9fe8e61cc8d11129e324c021bc30b62

2a34bb1e

History

res_pjsip_outbound_authenticator_digest: Prevent ABRT on cleanup

George Joseph authored 3 years ago

In dev mode, if you call pjsip_auth_clt_deinit() with an auth_sess
that hasn't been initialized, it'll assert and abort.  If
digest_create_request_with_auth() fails to find the proper
auth object however, it jumps to its cleanup which does exactly
that.  So now we no longer attempt to call pjsip_auth_clt_deinit()
if we never actually initialized it.

ASTERISK-29888

Change-Id: Ib6171c25c9fe8e61cc8d11129e324c021bc30b62