Skip to content
Snippets Groups Projects
  • Mark Michelson's avatar
    11ffcf66
    Restrict functionality when ACLs are misconfigured. · 11ffcf66
    Mark Michelson authored
    This patch has two main purposes:
    
    1) Improve warning messages when ACLs are configured improperly.
    2) Prevent misconfigured ACLs from allowing potentially unwanted
    traffic.
    
    To acomplish point (2) in most cases, whatever configuration object that
    the ACL belonged to was not allowed to load.
    
    The one exception is res_pjsip_acl. In that case, ACLs are their own
    configuration object. Furthermore, the module loading code has no
    indication that a ACL configuration had a failure. So the tactic taken
    here is to create an ACL that just blocks everything.
    
    ASTERISK-24969
    Reported by Corey Farrell
    
    Change-Id: I2ebcb6959cefad03cea4d81401be946203fcacae
    11ffcf66
    History
    Restrict functionality when ACLs are misconfigured.
    Mark Michelson authored
    This patch has two main purposes:
    
    1) Improve warning messages when ACLs are configured improperly.
    2) Prevent misconfigured ACLs from allowing potentially unwanted
    traffic.
    
    To acomplish point (2) in most cases, whatever configuration object that
    the ACL belonged to was not allowed to load.
    
    The one exception is res_pjsip_acl. In that case, ACLs are their own
    configuration object. Furthermore, the module loading code has no
    indication that a ACL configuration had a failure. So the tactic taken
    here is to create an ACL that just blocks everything.
    
    ASTERISK-24969
    Reported by Corey Farrell
    
    Change-Id: I2ebcb6959cefad03cea4d81401be946203fcacae